243465 - Help window shows error at bottom (but still works)

Status: RESOLVED FIXED

Description

[Jesse Ruderman]

Krueger said:

-----

This is minor, but still a bug. If you click on Help --> Help Contents you get
this screen:

http://www.lmhess.com/freebird/help.jpg

I see this in the Official 5/12 build and my own builds from 5/11 and 5/12. My
build from 5/08 works OK so this bug crept in somewhere between 5/09 and 5/11.

-----

Comment 1

[R.J. Keller]

--> me (not sure how this got to ben).

I've heard that this has happened but cannot reproduce. I'll try creating a new
profile.

Comment 2

[Jeff Walden [:Waldo]]

Looks like fallout from Ben's massive comm.jar & friends removal in bug 243091,
if I'm not mistaken.  The removed stuff contained a few DTDs we reference from
the old toolkit (being fixed in bug 243116), and with those DTDs gone the errors
show up.

Comment 3

[R.J. Keller]

Created attachment 148363 [details] [diff] [review]
Patch for Firefox Help Trunk

OK, bug fixed on the Firefox Help trunk. We'll probably have another Firefox
Help landing (much sooner than planned) to fix this and some other bugs.

I attached the patch that I just checked into the Firefox trunk that I'll port
over to Firefox ASAP.

Comment 4

[R.J. Keller]

Fix checked into the Firefox trunk.

Comment 5

[Henrik Skupin (:whimboo)]

Entity isn't found with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a)
Gecko/20040515 Firefox/0.8.0+ and error still appears.

-> Reopen bug.

Comment 6

[R.J. Keller]

Henrik: That problem is new and has nothing to do with the previous problem. I
checked in the fix for this early this morning. It was caused by a file that
wasn't checked in. I think it barely missed the nightly builds.