24355 - [regression] font size way too big on bugzilla pages

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[buster]

today, the font in text controls on the bugzilla pages is very large.  Make the
page lay out poorly.

Comment 1

[buster]

I suggest we consider this for M13, since it makes using bugzilla a real pain.
Don't know how many other pages might be effected by this same problem.

Comment 2

[buster]

Attachment: worlds smallest test case

Comment 3

[Akkana Peck]

This was true yesterday, too, but not in last Friday's build.

Comment 4

[Erik van der Poel]

This is due to one of my changes. Need to decide what to do about it.

Comment 5

[rods (gone)]

Thanks, tt looks like it happened on saturday, as far as I can tell.

Comment 6

[lchiang]

*** Bug 24269 has been marked as a duplicate of this bug. ***

Comment 7

[Erik van der Poel]

Fixed. By the way, was the font too TALL, or too WIDE? Please let me know!

Comment 8

[Akkana Peck]

Mostly, it was too wide. Looks much better now.

Comment 9

[Katsuhiko Momoi]

erik, Japanese plain text mail  font looks kind of squished as compared to what it used to look like
 prior to this bug. To what degree this fix would affect mail display? Should it bring back what it used 
to look like? which was nice and neat and somewhat smaller than the default HTML font?

Comment 10

[Erik van der Poel]

The default fonts used to be:

  user_pref("font.size.variable.x-western", 12);
  user_pref("font.size.fixed.x-western", 10);
  user_pref("font.size.unit", "pt");

Then I changed the above 3 values to 16/16/px. That resulted in the reporting
of this bug (24355), so I changed the values to 16/14/px. Could you try
12/10/pt again with ja, x-western and x-unicode to see if that fixes your
problem? Or, try 18/18/px with x-unicode. I don't know how our mail client
works, so I'm not sure whether x-western, ja or x-unicode would be effective.

Comment 11

[Akkana Peck]

For some reason, in English, both plaintext mail compose and the plaintext
editor now show up with proportional-width fonts, which is wrong -- they must
have fixed-width fonts.

I'm not sure if I should reopen this bug or file a new one.

Comment 12

[Katsuhiko Momoi]

erik, I tried various sizes you mentioned with x-unicode and that changes the results
and made the size smaller or bigger but none looked right to me. I think I'm seeing the
same thing as akkana. It may not be using the proportional font here and that changes the
font used from a Gothic type to something else for Japanese. Going back to 12/10/pt x-unicode
did not change back the font type to the one I used to see. So this could be due to some other
change.

Comment 13

[Akkana Peck]

I tried adding those user_pref lines to my prefs.js.  Changing
font.size.fixed.x-western changes the font in text fields, but has no effect on
the font used in the plaintext editor (and presumably also the plaintext mail
compose) window.  So that's probably a different bug.

Comment 14

[Akkana Peck]

Filed bug 24675 on fonts in plaintext edit/mail compose.

Comment 15

[buster]

hmmm...there were hardcoded values for font inside the editor plaintext rules, 
that rod removed (with my approval, after a thread that involved some subset 
of the editor folks, don't recall who exactly) to make it possible to set the 
font in text controls.  Maybe that hardcoding was where the plaintext mail 
compose was getting it's font style from.  It should get it from somewhere else, 
the editor C++ shouldn't know anything about it.  Probably somewhere in XUL.  
You could try adding that hardcode back in just to see if that's really where 
the font was coming from before.  Then we can talk about where it ought to be.

Comment 16

[Pierre Saslawsky]

Reopening. The pref files on unix and windows (unix.jx / winpref.js) have been 
updated but not the corresponding file on the Mac (macprefs.js).

Comment 17

[Erik van der Poel]

Pierre, this bug (24355) is about font *size*. The default pref files for
Windows and Unix were updated to add some default font *names*. So that is an
unrelated issue.

Could you tell me in more direct terms what the problem is on the Mac? Is the
default font now too big? Too small? Which default font has a size problem?
The variable width one, or the fixed width one? Thanks for any info!

Comment 18

[Erik van der Poel]

I talked to Pierre on the phone just now. His concern is that I checked some
changes into the Windows and Unix default pref files for bug 8801, thereby
making the default fonts Times and Courier on those platforms, but I didn't
make that change to the Mac default pref file, so the Mac is coming up with
the wrong default font. He says it looks like Helvetica or something. I have
created bug 24172 for this.

Comment 19

[Christine Hoffman]

Verified fixed.