243624 - Proxy: mode selector should require hostname AND port before enabling manual item

Status: RESOLVED WONTFIX

(Core :: Networking, defect)

Description

[benc]

I'm going to admit that I'm on a nitting/rant about consistently configuring
proxy correctly.

You can't use proxy unless the hostname and port number are given.

This feature (at first glance), seems to check only for hostname info.

So, the selector will show a hostname, no port config as available, even though
it is a useless config (browser will default to direct connections). This
happens all plats.

+const kProxyManual = ["network.proxy.ftp",
+                      "network.proxy.gopher",
+                      "network.proxy.http",
+                      "network.proxy.socks",
+                      "network.proxy.ssl"];


+  // If no proxy is configured, disable the menuitems.
+  // Checking for proxy manual settings.
+  var proxyManuallyConfigured = false;
+  for (var i = 0; i < kProxyManual.length; i++) {
+    if (GetStringPref(kProxyManual[i]) != "") {
+      proxyManuallyConfigured = true;

I'm working on my javascript skills, so if I have time later I'll try to hack a
patch.

On a related note, (at least on Mac, no time to check on others right now...),
if you select manual w/ no hostname and port in the prefs, the menu displays
with out the dot (so it looks like no mode is selected).