243629 - Land ChatZilla 0.9.63b

Status: VERIFIED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

It's got a long way, we have DCC and a shiny new preferences windows. About time
we landed it.

Comment 1

[James Ross]

Attachment: dcc.js part of the patch

Comment 2

[James Ross]

Attachment: config* part of the patch.

Comment 3

[James Ross]

Attachment: The rest.

This was split up to try and make review/etc. easier. :)

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

What's with the spelling mistake repeated all over:

IRCContentListenter

?

Comment 5

[James Ross]

(In reply to comment #4)
> What's with the spelling mistake repeated all over:
> 
> IRCContentListenter

It's called Dyslexia - at least I was /consistent/ or it would not work. :P 
(and this is what reviews are for :) )

Comment 6

[Samuel Sieb]

Comment on attachment 148512 [details] [diff] [review]
dcc.js part of the patch

const DCC_STATE_CONNECTED     =  4; // all going ok.
const DCC_STATE_DONE	      =  4; // finished ok.

Comment 7

[Samuel Sieb]

Comment on attachment 148513 [details] [diff] [review]
config* part of the patch.

r=[e-mail] with changes discussed on IRC.

Comment 8

[Samuel Sieb]

Comment on attachment 148514 [details] [diff] [review]
The rest.

r=[e-mail] with changes discussed on irc

Comment 9

[James Ross]

This has actuallyy landed, marking FIXED.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

[INFO]	Chatzilla 0.9.64 [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8a3) Gecko/20040725]
[INFO]	Please visit the ChatZilla homepage at
<http://www.mozilla.org/projects/rt-messaging/chatzilla/> for more information.

Verified FIXED