243649 - wrong channel opens up when I click on non-last entry in output of /pref initialURLs

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Jacob]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040421
Build Identifier: Chatzilla 0.9.63b [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040421]

When "initialURLs" pref contains more than one entry, clicking on the 
non-last element of the output of "/pref initialURLs" opens the wrong channel.
Namely it opens the "#channel;" (with with ";" wrongly appended).

For example if channel "irc://irc.mozilla.org/chatzilla" is in initialURLs,
and non-last, then clicking on it will open not the original channel
"#chatzilla", but the channel "#chatzilla;" .


Reproducible: Always
Steps to Reproduce:



Expected Results:  
One possible solution is to make initialURLs space-separated instead of
";"-separated (separated by a char that can never appear unencoded in 
the URL, that is); and recognize ';' as separator for back-compatibility.

Comment 1

[James Ross]

I have this fixed locally, I'll try to extract the relevant bit and attach sometime.

Comment 2

[Jacob]

(In reply to comment #1)
> I have this fixed locally, I'll try to extract the relevant bit and attach
sometime.

Please attach the fix.

Comment 3

[James Ross]

Attachment: Use arraySpeak to show array prefs, and parse arraySpeak format when setting.

This also has my fix to make the /pref command always show an error if the pref
doesn't exist (rather than having a JS error in some cases).

Comment 4

[Samuel Sieb]

This got fixed somewhere along the way.