243733 - Internally register to handle vCard attachment URLs

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Scott MacGregor]

Today if you double click on a vCard attachment in the message pane, we open up
the Windows vCard application.

We should internally register the AB for handling urls of this content type so
we can show them in our ab card UI.

Comment 1

[Scott MacGregor]

Attachment: the fix...create a vcard stream listener which can turn a stream into vCard UI

Comment 2

[Scott MacGregor]

Comment on attachment 149241 [details] [diff] [review]
the fix...create a vcard stream listener which can turn a stream into vCard UI

Now when you double click on a vCard attachment we bring up our own address
book card UI instead of calling out to Microsoft's address book.

When the address book content handler detects text/x-vcard, it creates a vcard
stream listener. the vcard stream listener  takes the vcard stream, turns it
into a buffer then shows an address book card representing the data.

Comment 3

[David :Bienvenu]

Comment on attachment 149241 [details] [diff] [review]
the fix...create a vcard stream listener which can turn a stream into vCard UI

one nit:

+nsMsgVCardStreamListener::~nsMsgVCardStreamListener()
+{
+  PR_FREEIF(m_dataBuffer);
+}

this can just be PR_Free, since we're in the desstructor, and don't care about
nulling out m_dataBuffer (and PR_Free checks for null anyway...).
sr=bienvenu...

Comment 4

[Scott MacGregor]

fixed on the trunk

Comment 5

[[e-mail]]

Comment on attachment 149241 [details] [diff] [review]
the fix...create a vcard stream listener which can turn a stream into vCard UI

>+    // create a stream listener to handle the v-card data
You might have been able to save your self some work using a stream loader, it
collects up the data into a buffer for you. Then the work you were doing in
OnStopRequest you move to OnStreamComplete.

>+      nsCOMPtr<nsISupportsInterfacePointer> ifptr = do_CreateInstance(NS_SUPPORTS_INTERFACE_POINTER_CONTRACTID, &rv);
That's a nice trick to pass an nsIAbCard to abNewCardDialog.xul - which
promptly calls QueryInterface on its parameter, thus defeating the object...

Comment 6

[Gregor Larson]

Is it possible the fix for this bug broke something?
I am now having a problem with "Add to Address Book" (right-click on address in
message header).

In Thunderbird version 0.6+ (20040601) win2k it is working.
... 2 days later ....
In Thunderbird version 0.6+ (20040603) win2k is is broken:
  - email address not filled in.

Comment 7

[[e-mail]]

Attachment: cleanup

Comment 8

[[e-mail]]

Comment on attachment 150131 [details] [diff] [review]
cleanup

Most of this patch is cleanup although there are one or two tweaks to get the
feature to work on my build, I don't know if they're strictly necessary.

Comment 9

[Scott MacGregor]

Comment on attachment 150131 [details] [diff] [review]
cleanup

Thanks for cleaning this up Neil. One comment. You enabled this feature for
seamonkey which is fine. I had it Thunderbird only. But you've now removed the
registration from Thunderbird so it won't work there. Please fix that. 

Also the nsISupportsInterfacePointer stuff that you removed was copied from
somewhere else (I don't remember where). You might want to clean up that caller
too while you are at it.

Comment 10

[Scott MacGregor]

Comment on attachment 150131 [details] [diff] [review]
cleanup

I misunderstood the thunderbird factory change. I see now that this still works
for thunderbird. thanks Neil.

Comment 11

[[e-mail]]

I've checked attachment 150131 [details] [diff] [review] into the trunk.

Comment 12

[Tommy Becker]

Has this landed on the branch?  None of the recent builds I've tried register TB
as the vCard handler.  Further, if I manually set the association and double
click a vCard, TB opens but nothing happens (doesn't display the address book or
the card).