243765 - Clean up css of xbl datepicker and xbl timepicker (make skinnable)

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040421
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040421

The xbl datepicker and xbl timepicker in datetimepickers currently use a mix of
css from content/datetimepickers and skin/datepicker, skin/timepicker.  Much of
the css in content/datetimepickers was originally in skin/eventDialog.css.  The
appearance css from both sources should be combined in skin/datetimepickers so
the components are skinnable and easier to reuse.

Reproducible: Always
Steps to Reproduce:

Comment 1

[gekacheka]

Attachment: zip of added skin files

Adds skin css files for minimonth, datepicker, timepicker
(combined and cleaned up from eventDialog).
  skin/classic/datetimepickers/minimonth.css
  skin/classic/datetimepickers/datepicker.css
  skin/classic/datetimepickers/timepicker.css
  skin/modern/datetimepickers/minimonth.css
  skin/modern/datetimepickers/datepicker.css
  skin/modern/datetimepickers/timepicker.css
Restores modern button images (currently classic and modern are same)
  skin/modern/datetimepickers/calendar_disabled.gif
  skin/modern/datetimepickers/calendar_down.png
  skin/modern/datetimepickers/calendar_hover.png
  skin/modern/datetimepickers/calendar_up.gif
  skin/modern/datetimepickers/clock_disabled.gif
  skin/modern/datetimepickers/clock_down.png
  skin/modern/datetimepickers/clock_hover.png
  skin/modern/datetimepickers/clock_up.gif
These replace the previous images (copies of the classic images), so
since the png files don't overwrite the gif files, the following can be
removed:
  skin/modern/datetimepickers/calendar_down.gif
  skin/modern/datetimepickers/calendar_hover.gif
  skin/modern/datetimepickers/clock_down.gif
  skin/modern/datetimepickers/clock_hover.gif

Comment 2

[gekacheka]

Attachment: content/datetimepickers/minimonth.css patch

Remove appearance css, import skin file.

Comment 3

[gekacheka]

Attachment: content/datetimepickers/datepicker.css patch

Remove appearance css, import skin css.

Comment 4

[gekacheka]

Attachment: content/datetimepickers/datepicker.xbl patch

Add/fix box class names.

Comment 5

[gekacheka]

Attachment: content/datetimepickers/timepicker.css patch

Remove appearance css, import skin css.

Comment 6

[gekacheka]

Attachment: content/datetimepickers/timepicker.xbl patch

Add/fix box classes.

Comment 7

[gekacheka]

Attachment: skin/classic/eventDialog.css patch

Remove old css moved elsehwere or no longer used.

Comment 8

[gekacheka]

Attachment: skin/modern/eventDialog.css patch

Remove old css moved elsewhere or no longer used.

Comment 9

[gekacheka]

Attachment: jar.mn patch

Adds new files, removes unused files.

Comment 10

[Mostafa Hosseini]

Comment on attachment 148624 [details]
zip of added skin files

New files checked into CVS.
Modified files updated.
jar.mn updated.

Comment 11

[Mostafa Hosseini]

Comment on attachment 148625 [details] [diff] [review]
content/datetimepickers/minimonth.css patch

Patch wouldn't work though. Had to apply it manually

Comment 12

[Mostafa Hosseini]

The eventDialog.css patched won't apply. Can you please fix them or at least
provide the actual files instead?

Comment 13

[gekacheka]

Attachment: skin/classic/eventDialog.css

Comment 14

[gekacheka]

Attachment: skin/modern/eventDialog.css

re comment #12, uploaded updated skin eventDialog.css files.

Comment 15

[Mostafa Hosseini]

Comment on attachment 148961 [details]
skin/classic/eventDialog.css

All looks good.
Questions:
#start-date-box is being used in printDialog.xul should it really be removed?
#dialog-box is being used in some dialog xuls. Should it really be removed?
#all-day-event-checkbox is still being used. Should it really be removed?
Is it that the css rules for theses ids are not necessary?

Comment 16

[gekacheka]

Attachment: printDialog.xul remove start-date-box

start-date-box can be removed from printDialog.xul as in above patch.
dialog-box is named only in files that do not load eventDialog.css so it is ok
to remove it in eventDialog.css
all-day-event-checkbox appears earlier in the file, so the removed declaration
is not needed.

Thanks for the careful review.

Comment 17

[Mostafa Hosseini]

Comment on attachment 148633 [details] [diff] [review]
jar.mn patch

skin/modern/calendar/datetimepickers/calendar_down.png
is being added and the gif one removed. The css files however both use the gif
file. Is this a mistake or am I missing something?

Comment 18

[gekacheka]

Attachment: skin/modern/datetimepickers/datepicker.css, timepicker.css patch

You're right, I should have updated the zip, here's the fixes.

Comment 19

[Mostafa Hosseini]

All review+ patches have been checked in.
All files that were not needed have been removed.

Cleaning up the date-time picker code was a huge contribution.
Thanks a lot gekacheka, way to go.

Comment 20

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!