24398 - adding new files should remind to add to packages-win

Status: VERIFIED WONTFIX

(mozilla.org :: Miscellaneous, task, P4)

Description

[matt]

When i check in a new file
I want a warning saying that i should
add the file to the packages-win file

Comment 1

[Daniel (Leaf) Nunes]

How would you like the warning, sir? In the newsgroups, via email, or as a
commitcheck blurb when you cvs add a file? Not all cvs adds are going to require
an update to the manifest files, though. 90% of them, aren't, in fact.

I suppose we could do a check for changes to lines with $(MAKE_INSTALL) on them
and spit something out. Too bad newsgroups are failing so miserably at
communicating important messages to people.

Comment 2

[Chris Yeh]

adding granrose to cc.

what about a test parameter to the packager script? you give it a source, a
destination, and a "--test" or something, so that it copies into a runnable
structure. that way people could make sure that everything would work with a
"packaged" build.

Comment 3

[Jon Granrose]

well, if someone wanted to run pkgcp.pl manually, you don't have to use a --test
parameter.  you can just run pkgcp.pl with the right arguments, and then go into
the browser directory and try to run mozilla.  But I think engineers have a
better chance of remembering to update the packages files than remembering how
to run pkgcp.pl.

How about adding pkgcp.pl to the tinderbox optimized clobber smoketests so that
it does the build, then calls pkgcp.pl to do the packaging, then runs the
browser from the packaged directory rather than from mozilla/dist/bin.  if it
works, green,  if it fails, orange.  that way people can see immediately after
their checkin that something doesn't work.

Comment 4

[Daniel (Leaf) Nunes]

*** Bug 24729 has been marked as a duplicate of this bug. ***

Comment 5

[Jon Granrose]

set to future.

the other question is do we want this notification for every file added?  I
think we only want it when people add files that will show up in dist/bin.  The
notification will quickly lose any use if people get spammed by it just for
checkin in new source.

Comment 6

[Daniel (Leaf) Nunes]

heeding granrose's argument. the best way to deal with keeping the package
manifests up to date is education, and that is already happening/has happened.

Comment 7

[Grace Bush]

v