243996 - cvs log for a revision should actually track a branch tied to the revision instead of tracking head

Status: RESOLVED FIXED

(Webtools Graveyard :: Bonsai, defect)

Description

[timeless]

What you get:

CVS Log 
mozilla/ layout/ html/ base/ src/ nsFrameManager.cpp (1.186.2.1)  lxr  Browse 
the source code as hypertext.  
diff  Compare any two version.  
blame   Annotate the author of each line.  
graph   View the revision history as a graph  
 
 
Rev Author Date  Log 
1.189 bzbarsky%mit.edu 2004-05-04 17:34   Subtract out the reflow hint from 
aMinChange when re-resolving out-of-flow
kids, in case they're not our descendants and need a reflow. Bug 170644,
r+sr=dbaron
 
...

What would be better:

CVS Log 
mozilla/ layout/ html/ base/ src/ nsFrameManager.cpp ([Select a 
branch|v]:1.186.2.1)  lxr  Browse the source code as hypertext.  
diff  Compare any two version.  
blame   Annotate the author of each line.  
graph   View the revision history as a graph  
 
 
Rev Author Date  Log 
1.186.2.1 bzbarsky%mit.edu 2004-04-13 18:56   Don't clobber 'pseudoTag' with 
random atoms from other style contexts; we need
it later on. Bug 231166, r+sr=dbaron, a=asa
 
1.186     

Where [|v] is populated with two lists, a list of parent branches (HEAD, 
MOZILLA_1_7_BRANCH) and an alphabetical list of branches/tags that match the 
revision listed. 

so the list would be:
HEAD
MOZILLA_1_7_BRANCH
-
AVIARY_1_0_20040515_BASE
AVIARY_1_0_20040515_BRANCH
CAMINO_0_8_BETA
MOZILLA_1_7_RC1
MOZILLA_1_7_RC2
THUNDERBIRD_0_6_BASE
THUNDERBIRD_0_6_BRANCH
THUNDERBIRD_0_6_RELEASE

selecting one of them would jump to a new cvslog page with that &rev='d and 
with the current numberical &rev= changed to &mark=.

Comment 1

[timeless]

Attachment: accept numeric versions for branch

Comment 2

[Mike Taylor [:bear]]

Comment on attachment 208308 [details] [diff] [review]
accept numeric versions for branch

this looks good and ran in my bonsai test environment

Comment 3

[Mike Taylor [:bear]]

apologies if I did not follow proper procedure in giving this a r+ from a request that timely made in IRC

Comment 4

[timeless]

Comment on attachment 208308 [details] [diff] [review]
accept numeric versions for branch

oops, minor error, dunno how that happened:

> @@ -84 +84 @@ my $browse_revtag = 'HEAD';
> -$browse_revtag = $::opt_rev if ($::opt_rev =~ /[A-Za-z]|^\d*(?:\.\d+)*$/);
> +$browse_revtag = $::opt_rev if ($::opt_rev =~ /[A-Za-z]|^\d+(?:\.\d+)*$/);

Comment 5

[timeless]

Comment on attachment 208308 [details] [diff] [review]
accept numeric versions for branch

mozilla/webtools/bonsai/cvslog.cgi 	1.35
mozilla/webtools/bonsai/cvslog.cgi 	1.37