244081 - nsChromeRegistry::UninstallPackage() incompatible types

Status: RESOLVED WORKSFORME

(Core Graveyard :: RDF, defect)

Description

[Iain MacDonnell]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040518 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040518 Firefox/0.8.0+


Trying to build from the aviary branch on Solaris / Sun Studio:

"nsChromeRegistry.cpp", line 2693: Error:
"nsChromeRegistry::UninstallPackage(const unsigned short*, int)" was previously
declared "nsChromeRegistry::UninstallPackage(const nsACString&, int)".
1 Error(s) detected.
gmake[4]: *** [nsChromeRegistry.o] Error 1
gmake[4]: Leaving directory
`/export/stuff/mozilla/thunderbird-20040518/mozilla/rdf/chrome/src'


This method apparently hasn't been written yet, so I'm not sure if it's the
prototype or the empty implementation that's wrong, but changing the
implementation to:

NS_IMETHODIMP nsChromeRegistry::UninstallPackage(const nsACString& aPackageName,
PRBool aUseProfile)

allows it to compile.



Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Roland Mainz]

CC:'ing the usual suspects.... :)

Comment 2

[Scott MacGregor]

I commented on this here for bsmedberg to look at:

http://bugzilla.mozilla.org/show_bug.cgi?id=239929

Comment 3

[Benjamin Smedberg]

You are building rdf/chrome/, you should be building chrome/. I don't know why.
Stop it.

Comment 4

[Scott MacGregor]

ben I don't think anyone is doing it intentionally. So telling the builds to
stop doing that isn't helpful :)

But the Mac thunderbird build is breaking here and it sounds like solaris
firefox builds break here as well. The semi-profile changes seem to be exposing
something weird in the build system here.  Maybe the ifdefs around building
rdf\chrome aren't correct for all flavors of the build...

Comment 5

[Iain MacDonnell]

(In reply to comment #3)
> You are building rdf/chrome/, you should be building chrome/. I don't know why.
> Stop it.

Oops! I think I goofed. My automated nightly thunderbird build failed due to
bug 244062, and I tried to patch that and continue where it left off, but I
typoed in setting up my build environment, and ended up without
MOZ_THUNDERBIRD set - this probably caused the attempt to build the wrong
chrome... sorry :/

Comment 6

[Scott MacGregor]

I'll see if that's what was breaking the OS X branch build too.

Comment 7

[Iain MacDonnell]

My aviary firefox nightly had failed at the same place. I worked around
bug 244062 and resumed it (without goofing on the build environment this
time), and it built successfully, so unless mscott still has a problem
with MacOS X, we can probably close this with a "builder is an idiot" cause...

Comment 8

[Iain MacDonnell]

mscott confirmed that the OSX builder made the same mistake as me.