244400 - Email selected events: only one event, repeated, run-together text, date problems

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

When multiple events are selected in the search pane and "email
selected events" is performed, the following problems occur:
 - Only one event is enclosed, and repeated multiple times.
 - The first two events run together.
 - The title of the events are not included in the plain text.

When any number of events are selected an "email selected events" is
performed, the following problems occur:
 - The "Summary" tag has two colons after it.
 - The description is labeled "summary" in the plain text, and
   labeled "description" in the vcalendar text, while the title
   is labeled "summary" in the vcalendar text.  Confusing.
 - The when dates are difficult to read because
   - full date given twice even if on same day
   - includes times even for all-day events
   - range ends at next day midnite for all-day events
   - uses initial dates for recurring events

Expected the multiple event email to
 - enclose every selected event
 - Include separation between events.
 - Include the summary (title) in the plain text.
   Placing it first will make it easier to scan the list of events.

Expected any event email to
 - Include a single colon after "Summary"
 - Include the same "Summary" in the plain text as in the vcalendar.
 - Include the description in the plain text.  Since the description
   may be multiple lines which may have some preformatting, it might
   best appear after the other headers, like the body of a message.
 - Provide readable "when":
   - full date given only once if on same day
   - omit times for all-day events
   - omit excluded end-day for all-day event range.
   - show next occurrence dates for recurring events.

Comment 1

[gekacheka]

Attachment: calendarMail.js patch: fix events loop, fix start date, adjust format

fix events loop so can send multiple events (not same event multiple times)
fix start date for recurring events (next occurrence, not initial)
fix end date for all-day events (one before excluded end date of range)
adjust plain text format:
  separate events
  include summary (subject, not multi-line description)
  include description (multi-line body)
  omitted extra colon (localization strings have colon)
  date not repeated if end date is same as start date
  times omitted for all-day events

Comment 2

[gekacheka]

Comment on attachment 149127 [details] [diff] [review]
calendarMail.js patch: fix events loop, fix start date, adjust format

Also reindented sendEvent.

Comment 3

[Mostafa Hosseini]

Comment on attachment 149127 [details] [diff] [review]
calendarMail.js patch: fix events loop, fix start date, adjust format

Patch fails.
Please provide the actual file.

Comment 4

[gekacheka]

Attachment: calendarMail.js

Full file, as requested.

Comment 5

[Mostafa Hosseini]

Checked into CVS.
Thanks

Comment 6

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!