244458 - sign.cmd contains Unix-like linebreak leading to OS/2 build error

Status: RESOLVED WORKSFORME

(NSS :: Build, defect)

Description

[Peter Weilbacher]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040415
Build Identifier: 

The file mozilla\security\nss\cmd\shlibsign\sign.cmd is in Unix format
(line breaks with only '0A' instead of '0D 0A') which breaks the compile
process on OS/2 with the following error (for both 1.7 branch and trunk):

nsinstall              -R -m 775
G:/MozCompile/trunk/obj_fullMNG_noPNG/nss/mangle.exe
G:/MozCompile/trunk/obj_fullMNG_noPNG/dist/bin
make.exe[5]: Leaving directory
`G:/MozCompile/trunk/mozilla/security/nss/cmd/shlibsign/mangle'
     1 +++   ?PARSE ARG dist objdir os_target therest?dist = forwardtoback(dist);
REX0013: Error 13 running
G:\MozCompile\trunk\mozilla\security\nss\cmd\shlibsign\sign.cmd, line 1:
Invalid character in program
make.exe[4]: *** [G:/MozCompile/trunk/obj_fullMNG_noPNG/dist/lib/softokn3.chk]
Error 255
make.exe[4]: Leaving directory
`G:/MozCompile/trunk/mozilla/security/nss/cmd/shlibsign'
make.exe[3]: *** [libs] Error 2
make.exe[3]: Leaving directory
`G:/MozCompile/trunk/obj_fullMNG_noPNG/security/manager'
make.exe[2]: *** [tier_40] Error 2
make.exe[2]: Leaving directory `G:/MozCompile/trunk/obj_fullMNG_noPNG'
make.exe[1]: *** [default] Error 2
make.exe[1]: Leaving directory `G:/MozCompile/trunk/obj_fullMNG_noPNG'
make: *** [build] Error 2

Reproducible: Always
Steps to Reproduce:

Comment 1

[Peter Weilbacher]

Attachment: mozilla/security/nss/cmd/shlibsign/sign.cmd with OS/2 style linebreaks

Comment 2

[Wan-Teh Chang]

sign.cmd is a text file.  When you check it out from
the cvs repository, cvs should convert it to the format
(line breaks) appropriate for the platform.  It seems
that your cvs command is not set up correctly.

Comment 3

[Mike Kaply [:mkaply]]

What about changing the file to binary with 0a 0d line endings to guarantee it
gets checked out correctly?

Comment 4

[Peter Weilbacher]

I guess this is one of the strange errors that only resolve itself after being
reported as bug. After several checkouts yesterday I tried again today and now I
do get the correct linebreak.
Resolving WFM.