24463 - Confirmation dialog does not dismiss when closing browser

Status: RESOLVED WORKSFORME

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build: 2000-01-19-13-M13(WIN), 2000-01-19-08-M13(LINUX)

1. From http://jimbob/trigger2.html, select any test from the drop-down and
   click Trigger case button
2. With the confirmation dialog open, click on the browser window to make it
   the active window
3. Click on the close box at the top right corner to close the browser

RESULT:
The browser closes and the confirmation dialog remains present.  Clicking OK
from the confirmation dialog does not actually install, but an Install.log does
get created.  Also, from Windows step #3 above can be reproduced by choosing
Close with the mouse right-button from the Windows task bar.

Macintosh is the only platform where I could not find a way to close the browser
without closing the confirmation dialog.

EXPECTED RESULT:
Confirmation dialog dismisses along with the browser similar to choosing Exit
from the File menu.

Comment 1

[Cathleen]

Looks like a regression bug for M13.  Possibly someone else broke us.

Comment 2

[Cathleen]

Jimmy, can you check if today's build still has this problem?  -thanks!

Comment 3

[Jimmy Lee]

Build: 2000-01-20-08-M13(LINUX), 2000-01-20-09-M13(WIN)

This problem still exists in today's builds.

Comment 4

[dbragg]

Marking M14 and accepting.

Comment 5

[dbragg]

I tried this with other parts of the program (specifically the bookmarks stuff) 
and the same thing happens.  I think either the program should prevent closure 
at that point or close everything.  This isn't an XPInstall-specific bug.

Here's what I tried outside of XPInstall:
1) click on Bookmarks/Manage Bookmarks
2) Close the browser
Results:
The bookmarks "manager" page stays open

Comment 6

[dbragg]

Reassigning to the browser team.
Suggestion for fix.  IMHO the program shouldn't just close all windows if 
someone closes the browser.  Instead, a messagebox should show up telling them 
they have "processes" (or whatever word we want to use) open and they should 
either close them or wait for them to finish.  This would be kind of like the 
"save" dialog you get in a word processor if you try to quit without saving the 
file.

The reason I suggest this messagebox instead of just closing all child windows 
(which would probably be ok for modal dialogs) is that some child windows may be 
part of a time consuming process (like downloading/installing) and simply 
closing all processes could have some serious side effects.  For example, see 
bug #24613.  That bug refers to a non-modal dialog that gives status to the user 
during installations.  If the user were to close the program during this process 
weird s**t happens.

Comment 7

[Cathleen]

after talking to Don, he thinks it's more of a XPToolKit bug.
reassign to Peter.  :-)

Comment 8

[Peter Trudelle]

clearing target milestone, reassigning to danm for triage (modality problem?),
cc self.
Closing a window is not equivalent to closing everything; only the Quit/Exit
command should trigger such an app shutdown attempt, with any subsequent
in-progress/unsaved-data notifications that may be appropriate.

Comment 9

[Dan M]

True, all Mozilla windows tend to be top-level, full-blown windows, any of which 
will keep the app alive on non-Mac platforms. If you're keen on demoting a window 
so it won't do this, you could use the "dependent" flag when opening it. But that 
makes the window dependent, which doesn't have the exact behaviour you may be 
looking for. We should probably add another flag like "dependent." "Minor," or 
something.

Comment 10

[Peter Trudelle]

*** Bug 24613 has been marked as a duplicate of this bug. ***

Comment 11

[Peter Trudelle]

Mass moving M19 bugs to M20

Comment 12

[Peter Trudelle]

Mass-moving all M20-M30 XPToolkit bugs to Future

Comment 13

[Jimmy Lee]

Nominating.

Comment 14

[Juan José Mata]

Setting target milestone to 'Future' since 'mozilla1.1alpha' has already passed.

Comment 15

[David Epstein]

Test case can be triggered from
http://www.mozilla.org/quality/smartupdate/xpinstall-trigger.html
Select any item from the Acceptance or Functional Test Case menu.

Comment 16

[Wayne Mery (:wsmwk)]

WFM, dialog is dismissed
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0