244634 - Quoted-printable encoded vcard not decoded on Add To Address Book

Status: RESOLVED INVALID

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Michael Kolmodin]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6) Gecko/20040116
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6) Gecko/20040116

When recievintg a message with a attched Vcard, there is a button "Add to
Personal Address book" besides a presenation string for the card. The
presentation string is correctly decoded. When clicking on the button, a new
window is opened. The title of this window is not decode, contains things like
'=F6'. The same applies to the content.

Source for the vCard is the following email MIME part:

------=_NextPart_000_000D_01C44266.3CC530F0
Content-Type: text/x-vcard;
        name="=?iso-8859-1?Q?Milj=F6_och_Revisionsfirma_Hans_Zackari.vcf?="
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
        filename="=?iso-8859-1?Q?Milj=F6_och_Revisionsfirma_Hans_Zackari.vcf?="

BEGIN:VCARD
VERSION:2.1
N:Zackari;Milj=F6 och Revisionsfirma Hans
FN:Milj=F6 och Revisionsfirma Hans Zackari
EMAIL;PREF;INTERNET:[e-mail]
REV:20040525T124034Z
END:VCARD

------=_NextPart_000_000D_01C44266.3CC530F0--



Reproducible: Always
Steps to Reproduce:
1. Read my mailbox
2. Click on button "Add to Personal Address Book"
3. Watch window with  quoted-printable content.

Actual Results:  
Nothing, besides that it looks bad. 

Expected Results:  
Titel and content decoded before it's displayed.

Comment 1

[Michael Kolmodin]

Attachment: Complete mail message

This message contains two parts: Some ISO-8859-1 quoted-printable text, and a
vCard encoded the same way. As by headers, produced by MS-Outlook. When opened,
triggers the bug described

Comment 2

[Michael Kolmodin]

Comment on attachment 149276 [details]
Complete mail message

When type is message/rfc822, looks even more strange in Bugzilla. Changing to
text/plain

Comment 3

[Mike Cowperthwaite]

See this in 
  Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a3) Gecko/20040806
Updating platform.

Comment 4

[石庭豐 (Seak, Teng-Fong)]

Yup, I could confirm this bug.  This is very important for i18n support.

Even worse, it seems TB wrongly interprets the format.  It've got a version 2.1
vCard, and TB makes the following mistakes:
1. If vcard contains empty fields like TEL;CELL:  CELL: is put in Fax field!
2. When QUOTED-PRINTABLE is in-line (within the vcard), TB can't interpret it
correctly either.
3. And sometimes the attached vCard isn't even shown.

TB needs to strictly follow RFC 2426, well, at least.

Comment 5

[Mike Cowperthwaite]

*** Bug 276233 has been marked as a duplicate of this bug. ***

Comment 6

[Wayne Mery (:wsmwk)]

Teng-Fong regarding your comment #4, vcard 2.1 support is bug 221991.
RFC2426 is bug 29106

Comment 7

[Lukasz Stelmach]

(In reply to 石庭豐 (Seak, Teng-Fong) from comment #4)
> 2. When QUOTED-PRINTABLE is in-line (within the vcard), TB can't interpret it
> correctly either.

Isn't it because it shoud say ENCODING=QUOTED-PRINTABLE? Section 2 of http://www.imc.org/pdi/vcard-21.txt says so.

See also: bug #953155

Comment 8

[石庭豐 (Seak, Teng-Fong)]

(In reply to Lukasz Stelmach from comment #7)
> Isn't it because it shoud say ENCODING=QUOTED-PRINTABLE? Section 2 of
> http://www.imc.org/pdi/vcard-21.txt says so.

Could you be more specific?  Because your so-called "section 2" is almost the whole text file!

Anyway, without spending hours reading your text file, I would say the answer to your question is "No, that's not the reason". Let me explain:

The ENCODING=QUOTED-PRINTABLE you're talking about is *inside* vCard, ie it's a part of vCard information.  While the QUOTED-PRINTABLE we are talking about in this bug is inside the email (as attachment), ie it's part of email whereas vCard is *encapsulated* inside it. So the "QUOTED-PRINTABLE" you're talking about is at another level and therefore it has nothing to do with this bug.

(In reply to Wayne Mery (:wsmwk) from comment #6)
> Teng-Fong regarding your comment #4, vcard 2.1 support is bug 221991.
> RFC2426 is bug 29106

Thx. Logically, this bug has no direct relationship to vCard (2.1 or 3.0) because vCard is encapsulated inside a MIME content and normally TB should extract the vCard stream from MIME part and then interpret vCard to extract information. But who knows, maybe TB is making some shortcut and trying to read vCard info directly without passing through MIME "decapsulation" (sorry, I just invented this word :p)

Comment 9

[石庭豐 (Seak, Teng-Fong)]

(In reply to Lukasz Stelmach from comment #7)
> (In reply to 石庭豐 (Seak, Teng-Fong) from comment #4)
> > 2. When QUOTED-PRINTABLE is in-line (within the vcard), TB can't interpret it
> > correctly either.
> 
> Isn't it because it shoud say ENCODING=QUOTED-PRINTABLE? Section 2 of
> http://www.imc.org/pdi/vcard-21.txt says so.

Oh sorry, I was a bit too fast (I needed to rush :p) Your comment was talking about my point 2 (QUOTED-PRINTABLE within the vcard)... It's years ago, and I can't remember if I have left any test case of it.

So, it's hard to say anymore. But this bug is very old. We'd better re-test it again to see if it's been fixed or not.

Comment 10

[Geoff Lankow (:darktrojan)]

I'm pretty sure the vCard in the message attached is invalid as mentioned above.