244689 - LXR doesn't handle mac line endings

Status: RESOLVED WONTFIX

(Webtools Graveyard :: MXR, defect)

Description

[Alex Vincent [:WeirdAl]]

Steps to reproduce:  Click on the URL in this bug.
Expected results: All the files have a short code excerpt.
Actual results:  One file (near the end of the search) generates a whopping 
amount of source code for the excerpt.

I thought LXR was only supposed to give us one line of source code per link... 
anyone know what happened?

Comment 1

[timeless]

you could read the bug ;-) (bug 40809)
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/parser/htmlparser/tests/html/40809_CR.html&rev=&cvsroot=/cvsroot

the file only has \r (mac line endings)

Comment 2

[timeless]

Attachment: detect mac line endings

Comment 3

[timeless]

Comment on attachment 154831 [details] [diff] [review]
detect mac line endings

>+sub notvcalled {

i'll rename the function at some point, it's used by other stuff in this file
and possibly elsewhere.

>+	    print "CVS Says this is binary<br>";

That's more for testing, i'll probably actually spit out <!-- this file had mac
line endings --> or <!-- CVS indicates this file is a binary --> or <!-- LXR
has determined that this file is a binary because ... -->

The testcase for this patch is:
http://landfill.mozilla.org/mxr/aviarybranch/source/toolkit/themes/pinstripe/gl
obal/filepicker.css
http://landfill.mozilla.org/mxr-test/aviarybranch/source/toolkit/themes/pinstri
pe/global/filepicker.css

Comment 4

[Christian Reis]

Comment on attachment 154831 [details] [diff] [review]
detect mac line endings

Couple of questions:

  - What's notvcalled? Can that be renamed to suggests what it does?

  - How about checking up-front if we have mac line endings instead of using a
goto? You're really only treating the first line anyway..

  - So you're abusing this patch to get -kb support too, eh? :-) That's okay
for an LXR bug, I guess, but morph the summary.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

mxr is gone, mass closing.
https://searchfox.org/ is a much better alternative.