244744 - clicking characters once in help triggers dialog "Opening help.dtd"

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[R.K.Aa.]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040525

Click Help->Help Contents
Click the tab "Index"
Click on one of the capital letters found there

Result:
An "open file" window appears with "Opening help.dtd" on titlebar, and the content:

"The file "help.dtd" is of type text/x-dtd (Document type definition), and
Mozilla does not know how to handle this file type. This file is located at:
jar:/locale/en-US/help/

What should Mozilla do with this file?

Open it with the default application (gedit)"

(etc.)

Expected: Nothing.
A double-click should (and does) trigger a collapes/uncollapse of the tree
structure below the C, D etc.

Once the character HAS been double-clicked once, the bogus "open" window no
longer appears when clicking once on that particular letter.

Comment 1

[R.K.Aa.]

and if you open the file you'll find - amongst others - this line:

<!-- added bt PW 1/29/02- please check for correctness-->

I believe "bt" is a typo for "by" :)

Comment 2

[R.J. Keller]

I cannot reproduce this bug.

Daniel, do you see this?

Comment 3

[Daniel Wang]

On Win2k, it opens help.dtd as a blank page.

Comment 4

[R.J. Keller]

Attachment: patch

I can't reproduce this problem still, but this patch should work considering
it's linking to about:blank instead of nothing (which might be causing the
problem). Tell me if I'm wrong, since I can't test the patch.

Comment 5

[[e-mail]]

See attachment 150018 [details] [diff] [review] (second part of patch) for an alternative solution.

Comment 6

[[e-mail]]

Comment on attachment 150090 [details] [diff] [review]
patch

New idea: just removing nc:link="" should work. It would be nice if you could
fix help-index1.rdf (13 times), plus change this file to unix line endings.

Comment 7

[R.J. Keller]

Attachment: Patch w/ neils comments.

This is the patch with Neil's comments. I also fixed some occurances of
nc:link="" in help-index1.rdf.

Comment 8

[R.J. Keller]

Comment on attachment 150096 [details] [diff] [review]
Patch w/ neils comments.

OK, we can do that patch you mentioned too. What bug is that patch part of?

Let's check this in anyway as a minor cleanup.

Comment 9

[R.J. Keller]

(In reply to comment #6)
> (From update of attachment 150090 [details] [diff] [review])
> New idea: just removing nc:link="" should work. It would be nice if you could
> fix help-index1.rdf (13 times), plus change this file to unix line endings.
> 

Where is help-index1.rdf doesn't use unix line endings? It appears to use it to
me. Maybe I'm just not seeing it ?

Comment 10

[[e-mail]]

Comment on attachment 150096 [details] [diff] [review]
Patch w/ neils comments.

As you noticed it's just help-indexAZ.rdf that you needed to fix the line
endings on. (Luckily it's not too big!)

Comment 11

[R.J. Keller]

Fix checked in.