nsProfileMigrator.cpp fails to build on BeOS AVIARY_1_0_20040515_BRANCH

RESOLVED FIXED in Firefox1.0

Status

()

Firefox
Migration
--
blocker
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: tqh, Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

unspecified
Firefox1.0
x86
BeOS
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8a) Gecko/20040515 Firefox/0.8.0+
Build Identifier: 

In

rv = dirService->Get(NS_UNIX_HOME_DIR, NS_GET_IID(nsILocalFile),
                        getter_AddRefs(regFile));

BeOS doesn't know of NS_UNIX_HOME_DIR.

Reproducible: Always
Steps to Reproduce:
(Reporter)

Comment 1

14 years ago
Created attachment 149360 [details] [diff] [review]
Fixes building errors.
(Reporter)

Comment 2

14 years ago
Created attachment 149361 [details] [diff] [review]
Correct file.
Attachment #149360 - Attachment is obsolete: true
(Reporter)

Comment 3

14 years ago
Comment on attachment 149361 [details] [diff] [review]
Correct file.

setting review
Attachment #149361 - Flags: review?(sergei_d)
(Reporter)

Comment 4

14 years ago
Created attachment 150215 [details] [diff] [review]
Correct patch for BeOS

This is the correct patch. As older firefox appreg is
~/config/settings/Firefox/appreg

We get the settings-dir apply 'Firefox' and add 'appreg'

It found my old profile.
Attachment #149361 - Attachment is obsolete: true
(Reporter)

Updated

14 years ago
Attachment #149361 - Flags: review?(sergei_d) → review-
(Reporter)

Comment 5

14 years ago
Created attachment 150217 [details] [diff] [review]
Without debug printfs

removed some debugging that should not be added to CVS.
Attachment #150215 - Attachment is obsolete: true
(Reporter)

Comment 6

14 years ago
Comment on attachment 150217 [details] [diff] [review]
Without debug printfs

requesting review
Attachment #150217 - Flags: review?(sergei_d)

Comment 7

14 years ago
Comment on attachment 150217 [details] [diff] [review]
Without debug printfs

r = sergei_d@fi.tartu.ee

So, were my suspects correct?:)
Attachment #150217 - Flags: review?(sergei_d) → review+
(Reporter)

Comment 8

14 years ago
(In reply to comment #7)
> (From update of attachment 150217 [details] [diff] [review])
> r = sergei_d@fi.tartu.ee
> 
> So, were my suspects correct?:)
> 

As always :)
(Reporter)

Comment 9

14 years ago
Setting to blocker for BeOS and target milestone.
Severity: normal → blocker
Target Milestone: --- → Firefox1.0
(Reporter)

Comment 10

14 years ago
Comment on attachment 150217 [details] [diff] [review]
Without debug printfs

Requesting sr (and hopefully commit on success)
Attachment #150217 - Flags: superreview?(bugs)
Comment on attachment 150217 [details] [diff] [review]
Without debug printfs

r/a=me for landing on aviary/trunk
Attachment #150217 - Flags: superreview?(bugs)
(Reporter)

Comment 12

14 years ago
I'll close this one when I can get a full build and verify. Currently stuck on
bug 251327
(Reporter)

Updated

13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.