245164 - Blacklist / Whitelist input fields should use inline autocomplete

Status: NEW

(Firefox :: General, enhancement)

Description

[Ben Basson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

When adding a site to the cookie or popup whitelist (or any other situation
where you type a domain into a whitelist/blacklist input field) inline
autocomplete should be used, and a drop down list should appear.

The behaviour should exactly mirror that of the location bar, with the source of
the proposed entries coming from the history. Internet Explorer has this feature
and it makes it very easy to whitelist sites from a dialog.

Reproducible: Always
Steps to Reproduce:
1. Tools > Options > Web Features > Add Site...
2. Type the address of the site you last visited in the input field


Expected Results:  
The value should be autocompleted and a drop-down list should appear for quick
selection of the right value, if desired.

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041018 Firefox/1.0

confirming
setting ->NEW,

the current copy/paste method is not what I would call advanced

(the UI changed a bit since 0.8)

Tools->Options->Privacy->Cookies->exceptions 
should have the "address of website" field prefilled with the current website.
(w or w/o autocomplete ?)

Comment 2

[Ben Basson]

Attachment: Add history autocomplete to permissions (black/whitelist) dialog

Makes the textbox consistent with the homepage setter textbox in main.xul by adding autocomplete and using the same class. 

Textbox is not quite as padded as before, but that's because autocomplete.css .padded has less padding than preferences.css #browserHomePage. Would it be worth sharing the #browserHomePage rule with this element?

Do we want to auto-fill the field with the active tab's URL? If so, full URL or domain only? The homepage setter does not do anything here as far as I can tell (although it does provide a "Use Current Page" button).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Won't this autocomplete full URLs, when the whitelist takes hosts only?

Comment 4

[Ben Basson]

It does, but the URL is trimmed to only its host when added to the list. Querying permissions.sqlite confirms.