Closed
Bug 245196
Opened 20 years ago
Closed 20 years ago
add color to quoted message parts
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird0.7
People
(Reporter: mscott, Assigned: mscott)
References
Details
(Whiteboard: fixed-aviary1.0)
Attachments
(3 files, 1 obsolete file)
Tracking bug for adding color to quoted border parts per discussion with Seth and Asa.
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.7
Assignee | ||
Comment 1•20 years ago
|
||
for now, the block cite color rules are in messageHeader.css They don't show up in editor at all yet. Once we figure out how to load a mail only CSS file in an editor instance, we'll break this code out into messageQuote.css.
Assignee | ||
Comment 2•20 years ago
|
||
nsIEditorStyleSheets::addStyleSheet might be the way we can make the editor instance load a messageQuotes.css chrome file at the presentation level.
Assignee | ||
Comment 3•20 years ago
|
||
See: http://lxr.mozilla.org/mozilla/source/editor/ui/composer/content/editor.js#415 for an example
Assignee | ||
Comment 4•20 years ago
|
||
Attachment #149722 -
Attachment is obsolete: true
Assignee | ||
Comment 5•20 years ago
|
||
Comment on attachment 149876 [details] [diff] [review] proper fix for mail compose and message display Hopefully we won't pay too much of a price for loading this style sheet when we create a new editor instance. Ditto for importing messageQuote.css into the message pane frame when we display a message. In addition to sharing the blockquote styles between mail compose and mail display, I took the liberty of moving the signature styles into the shared file as well. This makes it so the signature is now styled inside the compose window like we style it in the message pane which I think looks pretty cool.
Attachment #149876 -
Flags: review?(sspitzer)
Comment 6•20 years ago
|
||
Comment on attachment 149876 [details] [diff] [review] proper fix for mail compose and message display r=sspitzer, nice work figuring this out.
Attachment #149876 -
Flags: review?(sspitzer) → review+
Comment 7•20 years ago
|
||
can you attach a screen shot, for grins?
Assignee | ||
Comment 8•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: fixed-aviary1.0
Comment 9•20 years ago
|
||
*** Bug 227662 has been marked as a duplicate of this bug. ***
Comment 10•20 years ago
|
||
This doesn't appear to be working correctly, and there also appears no way to turn off the bars. I see both the new colour bars (yuk! IMHO) _and_ the traditional '>'. See attached screenshot. I have the following in user.js (inherited from my Mozilla profile, to disable the colour bars in Moz): user_pref("mail.quoted_graphical", false); user_pref("mail.quoteasblock", false); user_pref("mailnews.display.disable_format_flowed_support", true); Removing these results in the colour bars only, but I can't disable the colour bars and have just the traditional '>'.
Comment 11•20 years ago
|
||
Duh! Forgot to include: Mozilla Thunderbird 7.0 (Windows/20040623)
Comment 12•20 years ago
|
||
Does this fix include coloring of the quoted _text_ and shading the _background_ (not just the quote-bars)? FYI: Mozilla bug 90315 seeks to implement colored quote bars, text and backgrounds. Maybe you guys can _join efforts_ to fully implement this (not just the quote-bars). ;) Also, bug 90315 comment 34 by a colorblind person names some imortant criteria for color selection. Particularly: "... not putting green and red next to each other (blue could be inserted in between) - that might help the extreme cases." and "Still even for a completely colourblind person (monocromatic vision) the shades of grey on the background will indicate the difference in quotelevel .. as will the quotebars." Since there will be people annoyed by _any_ colors, I suggest the following UI (from bug 90315#c27): [x] Color quoted text [this setting would include the the "|" indicators] [x] Also color the quoted text's background (shades of gray)
Comment 13•20 years ago
|
||
1. No pref at all? 2. doesn't this throw when mail is not installed? sure it never will? if it does. editor won't init, probably be broken. if (editor && GetCurrentCommandManager() == aSubject) + { + var editorStyle = editor.QueryInterface(Components.interfaces.nsIEditorStyleSheets); + editorStyle.addStyleSheet("chrome://messenger/skin/messageQuotes.css"); gMsgCompose.initEditor(editor, window.content); } 3. Parish pointed out a valid bug. WeÄre having a number of combinations here, controlled by prefs and stylesheets, making this quite complicated. See <http://lxr.mozilla.org/seamonkey/source/themes/modern/messenger/messageBody.css#114>. REOPENing (or file new bug, if you prefer). 4. I personally much prefer thick (border-width: medium;) bars than double lined bars.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•20 years ago
|
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 14•20 years ago
|
||
re-closing. please file new bugs for your issues (desire for pref UI, consideration of other css styling). I don't understand issue #2 at all. That was a thunderbird specific change. How can mail not be installed? I'm still experimenting with the actual css colors & styles being used.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Comment 15•20 years ago
|
||
Filed bug 249109 or the regression
You need to log in
before you can comment on or make changes to this bug.
Description
•