245385 - the active theme should be selected instead of the last-selected one

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Steffen Wilberg]

While it's nice for extensions to have the one you've selected last being
selected again upon opening the manager, for themes it would be better to have
the active theme selected (and scrolled into view).
The advantage is that you don't have to look for the current theme.

Comment 1

[Koobs]

Perhaps a viable alternative to scrolling into view, would be to place the
current theme either:

- In its own "Current Theme" frame, at the top of the themes dialog, or
- First in the list of themes

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This is a pretty simple fix

Comment 4

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/8cb946fd4488

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090821 Minefield/3.7a1pre ID:20090821030931

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, how long you wanna let it bake? Seems like that we don't have any regression. Is it ready for asking approval1.9.2?

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 395025 [details] [diff] [review]
patch rev 1

We should take this simple low-risk fix on the 1.9.2 branch

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 395025 [details] [diff] [review]
patch rev 1

a192=beltzner

Comment 9

[Dave Townsend [:mossop]]

Pushed to branch: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9fa8f9a6c12d

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.2 with builds on OS X and Windows like Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090914 Namoroka/3.6a2pre (.NET CLR 3.5.30729) ID:20090914045622

I believe we can inject this test into one of our Litmus tests.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Now covered by the following Litmus test for Firefox 3.6:
https://litmus.mozilla.org/show_test.cgi?id=8168