245736 - importProgress dialog is unused and can be removed

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Description

[Stefan Borggraefe]

The purpose of this old dialog is covered by a wizard page of importDialog.xul
nowadays.

Comment 1

[Stefan Borggraefe]

Attachment: Patch

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 150150 [details] [diff] [review]
Patch


I think that the <jar.mn> part is enough:
.js/.xul removal happening automatically then !?

Comment 3

[Serge Gautherie (:sgautherie)]

<http://lxr.mozilla.org/mozilla/search?string=importProgress.>
{{
/mailnews/jar.mn, line 175 -- content/messenger/importProgress.xul
(import/resources/content/importProgress.xul)
/mailnews/jar.mn, line 176 -- content/messenger/importProgress.js
(import/resources/content/importProgress.js)
/mailnews/import/resources/content/importProgress.xul, line 51 -- <script
type="application/x-javascript" src="chrome://messenger/content/importProgress.js"/>
}}

Good to remove ;-)

Comment 4

[Stefan Borggraefe]

(In reply to comment #2)
> I think that the <jar.mn> part is enough:
> .js/.xul removal happening automatically then !?

No, you still need to remove the files from the CVS server. Removing the files
from jar.mn only stops the files to be included in the .jar files.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> (In reply to comment #2)
> > I think that the <jar.mn> part is enough:
> > .js/.xul removal happening automatically then !?
> 
> No, you still need to remove the files from the CVS server. Removing the files
> from jar.mn only stops the files to be included in the .jar files.

I thought I had seen/done jar.mm only patches, and the files were removed from
LXR (searches)...
May be that is not enough, or you want to do more than that ?

Comment 6

[Stefan Borggraefe]

(In reply to comment #5)
> I thought I had seen/done jar.mm only patches, and the files were removed from
> LXR (searches)...

You need to do the cvs remove, too. This doesn't happen automatically. Probably
Neil did this for you when he checked in your patches.

Just test this with the files from bug 245728. ;)

Comment 7

[Stefan Borggraefe]

Comment on attachment 150150 [details] [diff] [review]
Patch

Ok, I just learned Neil can give r and sr to MailNews patches, but not moa.
Only bienvenu, mscott or sspitzer can do that. So I'm asking David for sr and
moa.

TIA David!

Comment 8

[Stefan Borggraefe]

Fix checked in.