Can't drag scrollbars in Print Preview anymore (after bug 245024's patch landed)

VERIFIED FIXED in mozilla1.8alpha2

Status

()

Core
Print Preview
--
major
VERIFIED FIXED
14 years ago
12 years ago

People

(Reporter: stephend, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
mozilla1.8alpha2
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040606
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040606

Build ID: 2004-06-06-09, Windows XP.

Can't click scrollbars in Print Preview anymore (after bug 245024's patch landed)


Reproducible: Always
Steps to Reproduce:
1.  File | Print Preview
2.  Try to click the scrollbars
3.

Actual Results:  
Doesn't respond to click to drag events, but you can position the scrollbar by
clicking inside the bar's area.

Expected Results:  
Scrollbars should respond to mouse click events to drag.
(Reporter)

Comment 1

14 years ago
Happy Birthday, Neil!
Assignee: core.printing → neil.parkwaycc.co.uk
(Assignee)

Comment 2

14 years ago
Hmm... I'm sure I tested scrollbars on Linux...

(In reply to comment #1)
>Happy Birthday, Neil!
Eh?
(Reporter)

Comment 3

14 years ago
I don't have a linux box, but this definitely broke on Win32.

Comment 4

14 years ago
Linux tested,
Doesn't respond to drag events, but you can position the scrollbar by
clicking inside the bar's area.

Change title "can't click" to "can't drag"
OS: Windows XP → All
Summary: Can't click scrollbars in Print Preview anymore (after bug 245024's patch landed) → Can't drag scrollbars in Print Preview anymore (after bug 245024's patch landed)
(Assignee)

Comment 5

14 years ago
Created attachment 150428 [details] [diff] [review]
Proposed patch

Aha... click events are handled at the frame level, but mouse events are
handled using regular DOM events, so I've got to unblock them.
(Assignee)

Comment 6

14 years ago
Comment on attachment 150428 [details] [diff] [review]
Proposed patch

Is unblocking all XUL events safe?
Attachment #150428 - Flags: superreview?(jst)
Attachment #150428 - Flags: review?(jst)
Comment on attachment 150428 [details] [diff] [review]
Proposed patch

Maybe, maybe not, but none of this printing code is "safe" to start with, so I
don't so much care. r+sr=jst
Attachment #150428 - Flags: superreview?(jst)
Attachment #150428 - Flags: superreview+
Attachment #150428 - Flags: review?(jst)
Attachment #150428 - Flags: review+
(Assignee)

Comment 8

14 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

14 years ago
Thanks for fixing this Neil.

Verified FIXED with build 2004-06-19-08 on Windows XP (Seamonkey).
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.8alpha2
You need to log in before you can comment on or make changes to this bug.