245783 - Chatzilla is now completely broken in Firefox

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Steffen Wilberg]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040607
Firefox/0.8.0+ (Steffen)

I built Firefox from the AVIARY_1_0_20040515_BRANCH with irc. Upon opening
Chatzilla, I only see an empty window.

The cause is that Firefox doesn't ship the code in chrome://communicator/ and
chrome://navigator/ anymore (bug 243091).

Console says:
*** Failed to load overlay chrome://communicator/content/utilityOverlay.xul
*** Failed to load overlay chrome://communicator/content/tasksOverlay.xul

Javascript console says:
Error: onLoad is not defined

Venkman is hit by this as well. For DOMi, I've forked some files to
mozilla/browser/extensions (bug 241079).
Another option would be to sprinkle a few #ifndef MOZ_PHOENIX. Firefox doesn't
need nor want SeaMonkey's Tools, Windows and Help menus and Preferences dialog.
The problem with these solutions is that if you fork the extension one way or
another, you can't offer a single download for multiple programs. It's
preferable therefore to make the extension comletely independent from SeaMonkey
chrome.

Comment 1

[Steffen Wilberg]

I justed tested Chatzilla 0.9.63b: same result.

Comment 2

[James Ross]

Yeah yeah... I was going to file this bug tomorrow to indicate the progress I've
made. But since you've filed it for me, a status report:

  - I have got it up and running in nightly FF builds.
  - Tools and Window menu only exist when running on Seamonkey (Mozilla Suite).
  - Preferences can be accessed from Edit on Seamonkey, and [a different] Tools
on Firefox.
  - The component bar (in the statusbar) is only visible on Seamonkey.

Remaining known issues:

  - Clicking or otherwise trying to load non-irc: URLs result in a missing
function error.

Steffen, thanks for the clear bug report, even if we did know the details
already. ;)  I might have this working entirely by sometime tomorrow, with a
release (0.9.63bf) will hopefully follow.

Comment 3

[Steffen Wilberg]

Just tried 0.9.64. It works fine with Firefox's new extension manager. The
preferences dialog works as well, but you should consider making it resizable.
The chatzilla homepage link opens a blank window in Firefox.

But Chatzilla itself still dispalys a blank window.

Comment 4

[James Ross]

(In reply to comment #3)
> Just tried 0.9.64. It works fine with Firefox's new extension manager. The
> preferences dialog works as well, but you should consider making it resizable.
> The chatzilla homepage link opens a blank window in Firefox.
> 
> But Chatzilla itself still dispalys a blank window.

Yeah, 0.9.64 isn't actually any different from 0.9.63b in terms of core
functionality. 0.9.64a (very soon!) will, however, work in Firefox.

The preferences window *is* resizable when opened from ChatZilla, however we
have no control at all over the window flags used when *Firefox* opens it, so
we're stuck if you open it that way.

The homepage link (assuming you mean the one in the pref window) is probably yet
more fallout from 243091.

Comment 5

[Steffen Wilberg]

> The preferences window *is* resizable when opened from ChatZilla, however we
> have no control at all over the window flags used when *Firefox* opens it, so
> we're stuck if you open it that way.
All-in-one-gestures extension has a resizable options dialog. It uses this as
optionsURL:
javascript:opener.openDialog('chrome://allinonegest/content/pref/aioOptions.xul','','chrome,all,dependent');window.close();

> The homepage link (assuming you mean the one in the pref window) 
> is probably yet more fallout from 243091.
Yes, I mean that one. It doesn't work with Firefox 0.8 either when called from
Tools->Options->Extensions->Chatzilla->Options.
Maybe you can use something like openNewTabWith(url) or browser.addTab(url)?

Comment 6

[James Ross]

(In reply to comment #5)
> > The preferences window *is* resizable when opened from ChatZilla, however we
> > have no control at all over the window flags used when *Firefox* opens it, so
> > we're stuck if you open it that way.
> All-in-one-gestures extension has a resizable options dialog. It uses this as
> optionsURL:
>
javascript:opener.openDialog('chrome://allinonegest/content/pref/aioOptions.xul','','chrome,all,dependent');window.close();

Ewwwwwwwwwwww. :)

> > The homepage link (assuming you mean the one in the pref window) 
> > is probably yet more fallout from 243091.
> Yes, I mean that one. It doesn't work with Firefox 0.8 either when called from
> Tools->Options->Extensions->Chatzilla->Options.
> Maybe you can use something like openNewTabWith(url) or browser.addTab(url)?

Possibly. It works in Moz, though, so it's technically a toolkit bug. Not that I
have any hope that anything will ever be done about it.

Comment 7

[Steffen Wilberg]

On the other hand, the extension manager already provides direct access to the
homepage, so you could remove the link when in "Firefox mode".

Comment 8

[James Ross]

(In reply to comment #7)
> On the other hand, the extension manager already provides direct access to the
> homepage, so you could remove the link when in "Firefox mode".

Yeah. That is a possibility. However, I'm a bit stuck right now - a completely
clean Firefox 0.9 RC install *does not start* here (leaving me hating it even
more and unable to test ChatZilla 0.9.64a properly).

Comment 9

[Steffen Wilberg]

Clean as in empty program directory? Try running with -safe-mode. This disables
all extensions so you can uninstall extensions which break Firefox.
Or try moving/wiping your profile folder(s). There are multiple locations to
look in because of profile dir changes:
http://forums.mozillazine.org/viewtopic.php?t=81428

Comment 10

[James Ross]

(In reply to comment #9)
> Clean as in empty program directory? Try running with -safe-mode. This disables
> all extensions so you can uninstall extensions which break Firefox.
> Or try moving/wiping your profile folder(s). There are multiple locations to
> look in because of profile dir changes:
> http://forums.mozillazine.org/viewtopic.php?t=81428

Clean as in installed to empty folder, and no profiles in sight. I don't really
care much, I don't need to use it - I got some poor #firefox users to test
ChatZilla 0.9.64a anyway, which I've now released. :)

Comment 11

[Steffen Wilberg]

"The was an error starting ChatZilla...
NS_ERROR_FILE_NOT_FOUND
nsIFile.isDirectory
chrome://chatzilla/content/static.js
line 357

The menubar is blank.

Comment 12

[Steffen Wilberg]

The startup error I ran into was solved by resetting the pref
"extensions.irc.initialScripts", which pointed to an invalid location. I filed
bug 246273 about the startup error.

ChatZilla 0.9.64a now works fine in Firefox 0.9RC. Nice work, Silver!

Comment 13

[Steffen Wilberg]

It would be great if you could provide the necessary info for cz in bug 244381,
so that cz will be listed on update.mozilla.org once it launches in a few days.

Comment 14

[James Ross]

Ok, the patch to fix this bug needs a new directory in CVS. What's the best way
to do this? (Benjamin Smedberg said I don't need review to just create a
directory in CVS, I think)

Comment 15

[Steffen Wilberg]

I'm not sure about the new directory, mainly because I don't have a cvs account
yet. Maybe you need to add the directory, then the files, then cvs diff -uN.

But you should bump maxVersion in install.rdf to 0.9.0+, as that is the version
of Firefox since today. 0.9 is no longer sufficient.

Comment 16

[James Ross]

Attachment: Firefox compatibility stuff

Ok, here's the patch. Some of it's not pretty, but it works. Things it does:
  - adds two build dirs, "sm" and "ff", to make sure the right stuff is made.
  - a complete set of cut, copy, paste, and friends, in the commands.
  - menus re-hacked to...
     - match FF when on FF (Tools or Edit for Options, for example)
     - never quit anything *beyond* ChatZilla, so you can't kill your browser
by accident any more.
     - show 'close view' for channels you're not in any more.

Comment 17

[James Ross]

ChatZilla 0.9.65 has landed. I believe this bug is fixed now; if it is not
fixed, please re-open the bug stating why you don't believe it's fixed.

Until an XPI is made of 0.9.65, 0.9.64g will do as for testing as it is
basically the same codebase.