15.85 KB, patch
|Details | Diff | Splinter Review|
There are some recently introduced problems with the non-autoconf build that we need to fix. Specifically: 1) Need to link the LDAP command line tools using g++ or link with libstdc++. 2) mozilla/directory/c-sdk/config/Makefile was recently removed but it (or something equivalent) is needed for non-autoconf builds. 3) This file includes a dependency on Makefile which no longer exists: directory/c-sdk/ldap/clients/tools/Makefile.client
target for 5.14.
Status: NEW → ASSIGNED
OS: Windows XP → All
Priority: -- → P1
Target Milestone: --- → 5.14
An additional annoyance is that the SDK build depends on some X11 header files: cc -o HP-UXB.11.11_DBG.OBJ/cppsetup.o -c -g -Ae +Z -DHPUX -Dhppa -D_HPUX_SOURCE -D_REENTRANT -DHPUX11 +DAportable +DS1.1 -DXP_UNIX -DDEBUG -UNDEBUG -DDEBUG_davidhp -DINCLUDEDIR=\"/usr/include\" -DOBJSUFFIX=\".o\" -I../../dist/HP-UXB.11.11_DBG.OBJ/include -I../../dist/public/coreconf -I/usr/java/include cppsetup.c cpp: "def.h", line 29: error 4036: Can't open include file 'X11/Xosdefs.h'. cpp: "def.h", line 33: error 4036: Can't open include file 'X11/Xfuncproto.h'. gmake: *** [HP-UXB.11.11_DBG.OBJ/cppsetup.o] Error 1 gmake: Leaving directory `/tmp/ldapsdk_new/mozilla/coreconf/mkdepend' gmake: *** [libs] Error 2 gmake: Leaving directory `/tmp/ldapsdk_new/mozilla/coreconf' gmake: *** [PullSDKComponents] Error 2 gmake: Leaving directory `/tmp/ldapsdk_new/mozilla/directory'
I forgot to mention that the patch was contributed by David Boreham.
The X11 header file problem appears to be in the coreconf area which is private to Netscape, so we will ignore that problem. I have a revised patch for the other problems that I will post in a few minutes.
Created attachment 150940 [details] [diff] [review] revised fix: simplify build.mk even more Here is a revised fix. David, can you try this out in a non-autoconf build? It works for me on Linux but I do not have easy access to many platforms right now. I simplified build.mk by removing redundancy; hopefully I did not break anything.
Attachment #150343 - Attachment is obsolete: true
Created attachment 151164 [details] [diff] [review] correct fix (last attachment was incomplete and flawed)
Attachment #150940 - Attachment is obsolete: true
Fix committed to the trunk; reviewed by David Boreham: mozilla/directory/Makefile new revision: 5.5; previous revision: 5.4 mozilla/directory/c-sdk/build.mk new revision: 5.14; previous revision: 5.13 mozilla/directory/c-sdk/config/HP-UX.mk new revision: 5.2; previous revision: 5.1 mozilla/directory/c-sdk/config/Makefile.client (added) initial revision: 5.1 mozilla/directory/c-sdk/ldap/clients/tools/Makefile.client new revision: 5.7; previous revision: 5.6 mozilla/directory/c-sdk/ldap/clients/tools/Makefile.in new revision: 5.7; previous revision: 5.6 Fix bug # 245794 - LDAP C SDK non-autoconf build problems Add Makefile.client under mozilla/directory/c-sdk/config and call it from mozilla/directory/Makefile (this "new" Makefile.client is the same as the old mozilla/directory/c-sdk/Makefile that was recently cvs removed). Simplify the logic in mozilla/directory/build.mk and make sure the command line tools are linked with the C++ compiler on all platforms where necessary. Recognize HP/UX 11.11 (treated the same as 11.00). Replace an incorrect dependency on Makefile with a dependency on Makefile.client inside the command line tools Makefile.client.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.