Closed Bug 245810 Opened 20 years ago Closed 20 years ago

Help is broken (XML Parsing Error) in installer builds

Categories

(Firefox :: Installer, defect, P1)

Product:
Firefox
Component:
Installer
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox0.9

People

(Reporter: wgianopoulos, Assigned: bugs)

References

Details

(Keywords: fixed-aviary1.0, regression)

Attachments

(1 file)

patch
1.07 KB, patch
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040607 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040607 Firefox/0.8.0+

I installed the WIndows 6/7/2004 0.9 nightly in a clean directory and started it
with a clean profile.  If I select either Help->Help Contents I get the
following pop-up error:

XML Parsing Error: xml processing insstruction not at start of external entity
Location: chrome://help/content/help.xul
Line Number 1, Column 1:


^

Reproducible: Always
Steps to Reproduce:
1.  Install Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040607 Firefox/0.8.0+ in a clean directory and start with a fresh profile.
2.  Select Help -> Help Contents
3.

Actual Results:  
pop-up error

Expected Results:  
launched Help
WFM
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040607
Firefox/0.8.0+ zipped version
Hmm. guess I should have specified this is with the installer version.
Confirming on Installer build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040607
Firefox/0.8.0+

However, I deleted the chrome.rdf files in the program and profile directory b/c
the Help menu dialogs weren't even showing up.  This is with a new profile, but
I know I've heard of that specific issue before ...
I can confirm with the Installer version. Totally clean FF Dir and Profile.

UA: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040607
Firefox/0.8.0+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
dave_harper: Is this with or without Help installed? I don't use the installer
builds so that might be why I'm not seeing this.
WFM with a zip build.
But I can reproduce with an installer build.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040608
Firefox/0.8.0+ (Steffen)

To create an installer, call |make install| in mozilla/browser/installer.
FireFoxSetup.exe is in dist/installer then.
Severity: normal → major
Flags: blocking0.9?
Help is completely broken in installer builds.
Old or new profile doesn't matter.
Summary: Help -> Help Contents gives XML Parsing Error → Help is broken (XML Parsing Error) in installer builds
argh.  Plussing so ben looks at this.
Assignee: rlk → bugs
Component: Help Viewer → Installer
Flags: blocking0.9? → blocking0.9+
QA Contact: firefox.help → bugzilla
(In reply to comment #5)
> dave_harper: Is this with or without Help installed? I don't use the installer
> builds so that might be why I'm not seeing this.

Help comes packaged automatically in the Installer build AFAIK. I has done
previously.
I'd like to note that the help.jar file is not the cause of this problem. The
files in that JAR file are the exact same as teh ones in the ZIP builds, so
there couldn't be an issue when transferring the JAR.

The only thing I could think of is that the chrome might not be registered
correctly.
I think it is an error in chrome.rdf
installed-chrome.txt in zip builds:
content,install,url,jar:resource:/chrome/help.jar!/content/help/
locale,install,url,jar:resource:/chrome/help.jar!/locale/en-US/help/
skin,install,url,jar:resource:/chrome/help.jar!/skin/classic/help/

installed-chrome.txt in installer builds:
skin,install,url,jar:resource:/chrome/help.jar!/content/help/
locale,install,url,jar:resource:/chrome/help.jar!/content/help/
content,install,url,jar:resource:/chrome/help.jar!/content/help/
skin,install,url,jar:resource:/chrome/help.jar!/skin/help/
locale,install,url,jar:resource:/chrome/help.jar!/locale/en-US/help/
hmm. maybe i'm wrong :). I installed the latest Firefox Help build (off the
Firefox Help trunk) and got this error message with more information provided:

XML Parsing Error: xml processing instruction not at start of external entity
Location: chrome://help/content/help.xul
Line Number 1, Column 1:        <toolbox id="help-toolbox" class="toolbox-top"
mode="icons" iconsize="small" customizable
^

don't think this helps a whole lot, though.
I don't know what you guys are doing over at mozdev, but that isn't the problem
here. ;-)

Correcting installed-chrome.txt, so that it looks like the upper half of comment
12, fixes this.
(In reply to comment #14)
> I don't know what you guys are doing over at mozdev, but that isn't the problem
> here. ;-)
> 
> Correcting installed-chrome.txt, so that it looks like the upper half of comment
> 12, fixes this.

Steffen: 90% of Firefox Help development is done on MozDev. If I am reproducing
the problem on MozDev with additional information, it would be helpful.

The version of the Firefox Help viewer on mozdev is always more recent than the
trunk version. It could result in a lead.
Attached patch patch — — Splinter Review 
register chrome in the right location! this was broken by the winstripe
landing.
Checked in branch, only place where this is.
Status: NEW → RESOLVED
Closed: 20 years ago
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → Firefox0.9
Yes, it works now. -> verified.

NB: The installed-chrome.txt now looks like this:
skin,install,url,jar:resource:/chrome/help.jar!/content/help/
locale,install,url,jar:resource:/chrome/help.jar!/content/help/
content,install,url,jar:resource:/chrome/help.jar!/content/help/
skin,install,url,jar:resource:/chrome/help.jar!/skin/classic/help/
locale,install,url,jar:resource:/chrome/help.jar!/locale/en-US/help/
Status: RESOLVED → VERIFIED
(In reply to comment #18)
> NB: The installed-chrome.txt now looks like this:
> skin,install,url,jar:resource:/chrome/help.jar!/content/help/
> locale,install,url,jar:resource:/chrome/help.jar!/content/help/
> content,install,url,jar:resource:/chrome/help.jar!/content/help/
> skin,install,url,jar:resource:/chrome/help.jar!/skin/classic/help/
> locale,install,url,jar:resource:/chrome/help.jar!/locale/en-US/help/

Methinks that's bug 244479.


*** Bug 253603 has been marked as a duplicate of this bug. ***
This wasn't checked into the trunk yet. Reopening.
Status: VERIFIED → REOPENED
Keywords: fixed-aviary1.0
Resolution: FIXED → ---
I checked in Ben's patches (branch checkins 2004-06-08 19:54 - 19:55)
into the trunk. Should be fixed now.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
V on the trunk, 20040927 build Win2000.
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → installer
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: