245826 - Checkin for Bug 240552 broke clobber builds and builds w/ disable-cookie

Reporter

Description

•

20 years ago

The checkin for Bug 240552 broke both AIX and HP-UX tinderboxes. They are both
failing with similar errors.

AIX:
xlC_r -o nsInstallTrigger.o -c -DOSTYPE=\"AIX5.1\" -DOSARCH=\"AIX\"
-DHAVE_DEPENDENT_LIBS
-I/home/tbox/builds/tinderbox/AIX_5.1_Clobber/mozilla/xpinstall/src/../public
-I../../dist/include/xpcom -I../../dist/include/xpcom_obsolete
-I../../dist/include/string -I../../dist/include/jar -I../../dist/include/caps
-I../../dist/include/content -I../../dist/include/necko
-I../../dist/include/intl -I../../dist/include/locale
-I../../dist/include/libreg -I../../dist/include/js -I../../dist/include/pref
-I../../dist/include/widget -I../../dist/include/uriloader
-I../../dist/include/xpconnect -I../../dist/include/dom
-I../../dist/include/windowwatcher -I../../dist/include/plugin
-I../../dist/include/unicharutil -I../../dist/include/appshell
-I../../dist/include/docshell -I../../dist/include/cookie
-I../../dist/include/layout -I../../dist/include/zlib
-I../../dist/include/xpinstall -I../../dist/include
-I/home/tbox/builds/tinderbox/AIX_5.1_Clobber/mozilla/obj-tinder/dist/include/nspr
    -I.   -qflag=w:w      -DNDEBUG -DTRIMMED -O2 -qmaxmem=-1 -qalias=noansi  
-DMOZILLA_CLIENT -D_MOZILLA_CONFIG_H_ -DMOZILLA_VERSION=\"1.8a2\" -DAIX=1
-DHAVE_SYS_INTTYPES_H=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino
-DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1 -DHAVE_INT16_T=1
-DHAVE_INT32_T=1 -DHAVE_INT64_T=1 -DHAVE_INT64=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1
-DHAVE_UINT16_T=1 -DHAVE_DIRENT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1
-DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_LIBC_R=1 -DHAVE_LIBM=1
-DHAVE_LIBDL=1 -DHAVE_LIBC_R=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -D_REENTRANT=1
-DHAVE_RANDOM=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1
-DHAVE_LSTAT64=1 -DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1
-DHAVE_RES_NINIT=1 -DHAVE_LANGINFO_CODESET=1 -DHAVE_I18N_LC_MESSAGES=1
-DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DMOZ_WIDGET_GTK=1 -DMOZ_ENABLE_XREMOTE=1
-DMOZ_X11=1 -DMOZ_APP_NAME=\"mozilla\" -DMOZ_ENABLE_COREXFONTS=1
-DMOZ_EXTRA_X11CONVERTERS=1 -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1
-DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DHAVE_GSSAPI_GSSAPI_H=1
-DHAVE_GSSAPI_GSSAPI_GENERIC_H=1 -DHAVE_GSS_C_NT_HOSTBASED_SERVICE=1
-DMOZ_MATHML=1 -DMOZ_SVG=1 -DMOZ_SVG_RENDERER_LIBART=1 -DMOZ_LOGGING=1
-DMOZ_USER_DIR=\".mozilla\" -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -DMOZ_XUL=1
-DMOZ_PROFILESHARING=1 -DMOZ_PROFILELOCKING=1 -DSUNCTL=1
-DMOZ_BYPASS_PROFILE_AT_STARTUP=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1
-DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1 -DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1
-DMOZILLA_LOCALE_VERSION=\"1.8a\" -DMOZILLA_REGION_VERSION=\"1.8a\"
-DMOZILLA_SKIN_VERSION=\"1.5\" 
/home/tbox/builds/tinderbox/AIX_5.1_Clobber/mozilla/xpinstall/src/nsInstallTrigger.cpp
"/home/tbox/builds/tinderbox/AIX_5.1_Clobber/mozilla/xpinstall/src/nsInstallTrigger.cpp",
line 53.10: 1540-0836 (S) The #include file "nsIPermissionManager.h" is not found.
gmake[4]: *** [nsInstallTrigger.o] Error 1

HPUX:
Error 112: "nsInstallTrigger.cpp", line 53 # Include file
"nsIPermissionManager.h" not found.
    #include "nsIPermissionManager.h"
             ^^^^^^^^^^^^^^^^^^^^^^^^
Error 419: "nsInstallTrigger.cpp", line 287 # 'nsIPermissionManager' is used as
a type, but has not been defined as a type.
                                   nsIPermissionManager* aPermissionManager,
                                   ^^^^^^^^^^^^^^^^^^^^                     
Error 185: "nsInstallTrigger.cpp", line 311 # Left side of '->' requires a
pointer to class; type found was 'int'.
                    aPermissionManager->Add( uri, XPI_PERMISSION, aPermission );
                    ^^^^^^^^^^^^^^^^^^                                          
Error 172: "nsInstallTrigger.cpp", line 344 # Undeclared variable
'nsIPermissionManager'.
        nsCOMPtr<nsIPermissionManager> permissionMgr =
                 ^^^^^^^^^^^^^^^^^^^^                 
Error 321: "nsInstallTrigger.cpp", line 344 # A type argument was expected in
the specialization of template 'nsCOMPtr'.
        nsCOMPtr<nsIPermissionManager> permissionMgr =
                 ^^^^^^^^^^^^^^^^^^^^                 
Error 172: "nsInstallTrigger.cpp", line 345 # Undeclared variable
'NS_PERMISSIONMANAGER_CONTRACTID'.
                                do_GetService(NS_PERMISSIONMANAGER_CONTRACTID);
                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  
Error 187: "nsInstallTrigger.cpp", line 344 # Referenced object '@$nsCOMPtr' is
not a member of class nsCOMPtr<(int)0> ["nsInstallTrigger.cpp", line 344].
        nsCOMPtr<nsIPermissionManager> permissionMgr =
                                       ^^^^^^^^^^^^^  
Error 166: "nsInstallTrigger.cpp", line 347 # Arithmetic or pointer type
expected for operator '&&'; types found were 'class nsCOMPtr<(int)0>' and
'nsIURI *'.
        if ( permissionMgr && aLaunchURI )
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^  
Error 585: "nsInstallTrigger.cpp", line 359 # Expected an operator before '::'.
                                   nsIPermissionManager::ALLOW_ACTION,
                                                       ^^             
Error 585: "nsInstallTrigger.cpp", line 362 # Expected an operator before '::'.
                                   nsIPermissionManager::DENY_ACTION,
                                                       ^^            
Error 172: "nsInstallTrigger.cpp", line 359 # Undeclared variable
'nsIPermissionManager'.
                                   nsIPermissionManager::ALLOW_ACTION,
                                   ^^^^^^^^^^^^^^^^^^^^               
Error 172: "nsInstallTrigger.cpp", line 362 # Undeclared variable
'nsIPermissionManager'.
                                   nsIPermissionManager::DENY_ACTION,
                                   ^^^^^^^^^^^^^^^^^^^^              
Error 699: "nsInstallTrigger.cpp", line 362 # Error limit reached; halting
compilation.
                                   nsIPermissionManager::DENY_ACTION,
                                   ^^^^^^^^^^^^^^^^^^^^              
make[4]: *** [nsInstallTrigger.o] Error 2
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory
`/tmp_mnt/proj/mozilla/build/tinderbox/SeaMonkey/HP-UX_B.11.00_Clobber/mozilla/xpinstall/src'

Daniel Veditz [:dveditz]

Assignee

Comment 1

•

20 years ago

AIX and HP-UX are not building any of the default extensions. Arg!

And there's no apparent compiler define you can use to ifdef out code depending
on whether they're being built or not. Double arg!

Daniel Veditz [:dveditz]

Assignee

Comment 2

•

20 years ago

Oddly, extensions/cookie gets clobbered even though it's not built. How does it
know to do that? How did these two browsers function back in the not-so-long-ago
days when the cookie code really lived in extensions/cookie?

A quick fix would be to add --enable-extensions=cookie to the mozconfig files,
but I've got to assume it was probably ripped out for a reason.

Philip K. Warren

Reporter

Comment 3

•

20 years ago

Actually the AIX tinderbox is building all extensions:

-->mozconfig<----------------------------------------
#mk_add_options MAKEFLAGS=-s
#MAKEFLAGS=-s

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-tinder

# SVG enabled for now
mk_add_options MOZ_INTERNAL_LIBART_LGPL=1
MOZ_INTERNAL_LIBART_LGPL=1
ac_add_options --enable-svg
ac_add_options --enable-svg-renderer-libart

export FT2_CONFIG=/opt/freeware/bin/freetype-config

ac_add_options --enable-optimize="-O2 -qmaxmem=-1 -qalias=noansi"
ac_add_options --enable-extensions=all
ac_add_options --enable-crypto
ac_add_options --enable-mathml
ac_add_options --enable-ctl
ac_add_options --enable-calendar
ac_add_options --disable-debug
ac_add_options --disable-tests
ac_add_options --disable-auto-deps

# compiler flags
CC=xlc_r
CXX=xlC_r
LDFLAGS='-bh:5'
LANG=C
-->end mozconfig<----------------------------------------

Philip K. Warren

Reporter

Comment 4

•

20 years ago

I changed the build target for the tinderbox from 'build' to 'build_all_depend'
to see if this resolves the problem for now.

Christian :Biesinger (don't email me, ping me on IRC)

Updated

•

20 years ago

Depends on: 245835

Daniel Veditz [:dveditz]

Assignee

Comment 5

•

20 years ago

Attached patch move nsIPermissionManager.idl to netwerk — Details — Splinter Review

After talking with bryner and darin I'm moving nsIPermissionManager.idl into
netwerk. Not a great place, but it can keep nsIPasswordManager company down
there.

Filed bug 245835 on undoing this move, possibly by moving the shared permission
manager code from extensions to, say, embedding/policy or something.

timeless

Comment 6

•

20 years ago

for the record, the problem is that bug 240552 made tier_50 depend on tier_94.

OS: AIX → All

Hardware: Other → All

Summary: Checkin for Bug 240552 broke AIX and HP-UX builds → Checkin for Bug 240552 broke clobber builds and builds w/ disable-cookie

Dan M

Comment 7

•

20 years ago

Thunderbird is one of those --disable-cookies apps. Won't you also have to add
cookies to the list of extensions to build in mail/config/mozconfig? Isn't
T-bird quite busted right now?

Sorry I missed that in the review. Permission manager stuff really is core code,
not an extension. Need to get that fixed, obviously. And I second bug 245835,
undo this evil ASAP.

Scott MacGregor

Comment 8

•

20 years ago

cc'ing myself since 245835 also broke Thunderbird.

Daniel Veditz [:dveditz]

Assignee

Comment 9

•

20 years ago

Thunderbird will not have to build cookie. XPinstall will work just fine if it
can't instantiate the permission manager, it just needs the iface at compile time.

Checked in to trunk and 1.7 branch after OK from bryner and darin for this
band-aid solution. Hope mvl isn't too torqued off at my dismembering the
permission manager until we come up with something better.

Severity: normal → blocker

Status: NEW → RESOLVED

Closed: 20 years ago

Flags: blocking1.7?

Keywords: fixed1.7

Resolution: --- → FIXED

Asa Dotzler [:asa]

Updated

•

20 years ago

Flags: blocking1.7?

David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)

Updated

•

20 years ago

Whiteboard: needed-aviary1.0

David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)

Updated

•

20 years ago

Whiteboard: needed-aviary1.0 → fixed-aviary1.0

Myk Melez [:myk] [@mykmelez]

Updated

•

20 years ago

Product: Browser → Seamonkey

Bugzilla

Quick Search

Checkin for Bug 240552 broke clobber builds and builds w/ disable-cookie

Categories

(SeaMonkey :: Build Config, defect)

Tracking

(Not tracked)

People

(Reporter: pkwarren, Assigned: dveditz)

References

Details

(Keywords: fixed1.7, Whiteboard: fixed-aviary1.0)

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Updated

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Updated

Updated

Updated

Updated

Attachment

General

Description

File Name

Content Type