uninstall button has no image when disabled

RESOLVED FIXED in mozilla1.7

Status

()

Toolkit
Add-ons Manager
--
minor
RESOLVED FIXED
14 years ago
10 years ago

People

(Reporter: Steffen Wilberg, Assigned: Steffen Wilberg)

Tracking

({polish})

unspecified
mozilla1.7
x86
Windows XP
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-aviary1.0)

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040608
Firefox/0.8.0+ (Steffen)

Open the extension manager and select the DOM inspector.
-> the uninstall button has no image.
Select another extension (which is not locked).
-> the red X image appears on the button.

Note that disabled buttons usually don't loose their images, for example the
"use theme" button in the theme manager.

This was already visible with Qute and now affects Winstripe.
(Assignee)

Comment 1

14 years ago
Created attachment 150240 [details] [diff] [review]
don't use the placeholder instead of the real image

This appears to be a leftover from image-less times. Because the right css rule
is a few lines up:

#uninstallButton[disabled="true"] {
  list-style-image: url("chrome://mozapps/skin/extensions/actionbuttons.png");
  -moz-image-region: rect(20px, 20px, 40px, 0px) !important;
}

Only the first file is in use now, but having different versions of the same
file is confusing, so I changed them both.
(Assignee)

Comment 2

14 years ago
patch ready.
Flags: blocking0.9?
(Assignee)

Comment 3

14 years ago
Comment on attachment 150240 [details] [diff] [review]
don't use the placeholder instead of the real image

The image for the disabled uninstall button is available, so let's use it.
Attachment #150240 - Flags: review?(bugs)
(Assignee)

Updated

14 years ago
Target Milestone: --- → Firefox0.9
r=me, checked in. 
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

14 years ago
Comment on attachment 150240 [details] [diff] [review]
don't use the placeholder instead of the real image

patch already checked in -> removing review request
Attachment #150240 - Flags: review?(bugs)
(Assignee)

Updated

14 years ago
Flags: blocking0.9?
Whiteboard: fixed-aviary1.0
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.