245840 - uninstall button has no image when disabled

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Steffen Wilberg]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040608
Firefox/0.8.0+ (Steffen)

Open the extension manager and select the DOM inspector.
-> the uninstall button has no image.
Select another extension (which is not locked).
-> the red X image appears on the button.

Note that disabled buttons usually don't loose their images, for example the
"use theme" button in the theme manager.

This was already visible with Qute and now affects Winstripe.

Comment 1

[Steffen Wilberg]

Attachment: don't use the placeholder instead of the real image

This appears to be a leftover from image-less times. Because the right css rule
is a few lines up:

#uninstallButton[disabled="true"] {
  list-style-image: url("chrome://mozapps/skin/extensions/actionbuttons.png");
  -moz-image-region: rect(20px, 20px, 40px, 0px) !important;
}

Only the first file is in use now, but having different versions of the same
file is confusing, so I changed them both.

Comment 2

[Steffen Wilberg]

patch ready.

Comment 3

[Steffen Wilberg]

Comment on attachment 150240 [details] [diff] [review]
don't use the placeholder instead of the real image

The image for the disabled uninstall button is available, so let's use it.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

r=me, checked in. 

Comment 5

[Steffen Wilberg]

Comment on attachment 150240 [details] [diff] [review]
don't use the placeholder instead of the real image

patch already checked in -> removing review request