245880 - Missing icons due to broken links in Winstripe

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[PikeUK]

Here's a list of (some of the) broken links in Winstripe that cause various
icons to be missing (mainly in the JS console and print preview/page setup windows):

classic/browser/browser.css
---------------------------

.toolbarpaletteitem-box[type="bookmarks-toolbar"][place="palette"] {
  [...]
  background: url("chrome://browser/skin/Bookmarks-folder.png") no-repeat;
}

#sidebar-throbber[loading="true"] {
  list-style-image: url(chrome://global/skin/icons/Loading.gif);
}

classic/global/console.css
--------------------------

.console-row[type="error"],
.console-row[type="exception"] {
  list-style-image: url("chrome://global/skin/icons/alert-error.gif");
}

.console-row[type="warning"] {
  list-style-image: url("chrome://global/skin/icons/alert-exclam.gif");
}

.console-row[type="message"] {
  list-style-image: url("chrome://global/skin/icons/alert-message.gif");
}

classic/global/console/console.css
----------------------------------

.console-row[type="message"] {
  list-style-image: url("chrome://global/skin/icons/Message.png");
}

classic/global/global.css
-------------------------

.message-icon {
  list-style-image: url("chrome://global/skin/icons/Message.png");
}

classic/global/printing.css
---------------------------

.toolbar-portrait-page {
  list-style-image: url("chrome://global/skin/icons/pg-portrait-small.gif");
}

classic/global/printPageSetup.css
---------------------------------

.portrait-page {
  list-style-image: url("chrome://global/skin/Portrait.png");
}

.landscape-page {
  list-style-image: url("chrome://global/skin/Landscape.png");
}

classic/global/printPreview.css
-------------------------------

.toolbar-portrait-page {
  list-style-image: url("chrome://global/skin/Portrait-small.png");
}

.toolbar-landscape-page {
  list-style-image: url("chrome://global/skin/Landscape-small.png");
}

classic/global/progressmeter.css
--------------------------------

progressmeter[mode="undetermined"] {
  background: url("chrome://global/skin/progressmeter/progressmeter-busy.gif")
repeat-x 0% 50%;
}

(I think this has been missing for quite a while).

classic/mozapps/downloads/downloads.css
---------------------------------------

#cleanUpButton[disabled="true"] {
  list-style-image:
url("chrome://mozapps/skin/downloads/downloadCleanupDisabled.png");
}

download[state="0"], download[state="-1"], download[state="4"], 
download[state="5"], download[state="6"] {
  [...]
  background-image: url("chrome://mozapps/skin/downloads/downloadFader.png");
}

Comment 1

[Steffen Wilberg]

The links will work fine once we've got icons for these in Winstripe. I searched
my tree for these icons. Most of them are Qute only. Qute icons are in various
skins directories, whereas Winstripe icons are in browser/themes and
toolkit/themes. We could of course package the Qute icons, but I'd prefer not to
mix themes.

The only Winstripe icon I found was
mozilla/toolkit/themes/winstripe/global/icons/pg-portrait-small.gif.

But as long as we don't have the respective landscape icon...

Comment 2

[PikeUK]

Presumably #sidebar-throbber could use the same icon as the tab throbber.

.console-row[type="message"] could possibly use
chrome://global/skin/icons/Question.png

Looks like we don't even use chrome://global/skin/console.css, or am I missing
something?

And it would definitely be nice to get an icon for
#cleanUpButton[disabled="true"] in before 0.9.

Comment 3

[Steffen Wilberg]

> Presumably #sidebar-throbber could use the same icon as the tab throbber.
Sure. Qute does that as well.

> .console-row[type="message"] could possibly use
> chrome://global/skin/icons/Question.png
Indeed. I think the reference to the missing
chrome://global/skin/icons/Message.png is a mistake.
And Qute uses its own question mark here as well.

> Looks like we don't even use chrome://global/skin/console.css, or am I missing
> something?
console.xul references chrome://global/skin/console/console.css instead, which
is located in mozilla/toolkit/themes/winstripe/global/console/console.css. The
unused one is one directory up.
Bah, I *need* lxr for the aviary branch!
 
Another problem with the console is that the link appearance is gone. I already
reopened my bug 207403.

> And it would definitely be nice to get an icon for
> #cleanUpButton[disabled="true"] in before 0.9.
Right, and it shouldn't be that hard to derive it from the not-disabled image.

Are you going to write a patch for these changes? Since you came up with that.

Comment 4

[PikeUK]

(In reply to comment #3)
> Are you going to write a patch for these changes? Since you came up with that.

I was hoping to leave it to someone who knows what they're doing in this
department like the theme authors.

Comment 5

[Steffen Wilberg]

They probably want to concentrate on improving more icons, like the reworked
find-in-page-icon that was checked in yesterday.
I'll make a patch later today and ask them for review. I've already cc'ed Kevin.
Don't know if Stephen has a bugzilla account.

Comment 6

[Steffen Wilberg]

Attachment: fix sidebar-throbber and console-row[type="message"]

as suggested by Pike.

Comment 7

[Steffen Wilberg]

Comment on attachment 150488 [details] [diff] [review]
fix sidebar-throbber and console-row[type="message"]

> #sidebar-throbber[loading="true"] {
>-  list-style-image: url(chrome://global/skin/icons/Loading.gif);
>+  list-style-image: url("chrome://browser/skin/Throbber-small.gif");
It was called Loading.gif in Qute:
http://lxr.mozilla.org/seamonkey/source/browser/base/skin/browser.css#738
It's called Throbber-small.gif in Winstripe.
This displays the throbber in the sidebar left to the close button when loading
a bookmark in there.

> .console-row[type="message"] {
>-  list-style-image: url("chrome://global/skin/icons/Message.png");
>+  list-style-image: url("chrome://global/skin/icons/Question.png");
Same here (Qute version):
http://lxr.mozilla.org/seamonkey/source/toolkit/components/console/skin/console
.css#118
This is the third category in the Javascript console, besides error and
warning.

I didn't remove the unused file
mozilla/toolkit/themes/winstripe/global/console.css because I don't want to
risk breaking anything a few days before the release.

Kevin, please have a look. Is this okay with the Winstripe team? Check it in
yourself if it suites you, I don't have a cvs account yet.

Comment 8

[Steffen Wilberg]

Comment on attachment 150488 [details] [diff] [review]
fix sidebar-throbber and console-row[type="message"]

Moving review request to Mike. This is just about correcting two filenames.

Comment 9

[Kevin Gerich]

Apologies for not doing this sooner Steffen. Fix checked in on branch.

Comment 10

[Steffen Wilberg]

Comment on attachment 150488 [details] [diff] [review]
fix sidebar-throbber and console-row[type="message"]

Thanks Kevin. Are you going to check this into the trunk as well? I can do that
as well now if you want.