Closed
Bug 245917
Opened 20 years ago
Closed 18 years ago
About Mozilla Thunderbird or About Thunderbird, pick one
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird2.0
People
(Reporter: edgrale, Assigned: edgrale)
Details
(Keywords: verified1.8.1.3)
Attachments
(1 file, 1 obsolete file)
1000 bytes,
patch
|
mscott
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040607 Firefox/0.8.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040607 Firefox/0.8.0+ A duplicate of bug http://bugzilla.mozilla.org/show_bug.cgi?id=238138 but for Thunderbird. "The menu item under Help is called "About Mozilla Thunderbird"; the resultant dialog is titled "About Thunderbird." These match in every other application I can think of; probably should pick one or the other." Reproducible: Always Steps to Reproduce: 1. Start thunderbird 2. Help -> About
Assignee | ||
Comment 1•20 years ago
|
||
I believe that these lines should change in mail/base/locale/aboutDialog.dtd -<!ENTITY aboutDialog.title "About &brandShortName;"> +<!ENTITY aboutDialog.title "About &brandFullName;"> and -<!ENTITY aboutLink "< About &brandShortName;"> +<!ENTITY aboutLink "< About &brandFullName;"> I don't know how to write a patch so...
Assignee | ||
Comment 2•20 years ago
|
||
Comment 3•20 years ago
|
||
Comment on attachment 151039 [details] [diff] [review] change brandshortname to brandFullName hmm... shouldn't rlk be the default owner of this bug?
Attachment #151039 -
Flags: review?(rlk)
Updated•20 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: stolenclover
Comment 4•20 years ago
|
||
Comment on attachment 151039 [details] [diff] [review] change brandshortname to brandFullName Looks good to me, but this requires mscott's review for checkin. There isn't any help documentation for Thunderbird (well, there is, but it's far from complete). I'm not sure why this component exists.
Attachment #151039 -
Flags: superreview?(mscott)
Attachment #151039 -
Flags: review?(rlk)
Attachment #151039 -
Flags: review+
Comment 6•20 years ago
|
||
Is this one a go or what?
Assignee | ||
Comment 7•20 years ago
|
||
I've been waiting for it to be checked in. Not that it is that of a big deal, but would be nice to have my first patch approved ;)
Comment 8•20 years ago
|
||
(In reply to comment #7) > I've been waiting for it to be checked in. Not that it is that of a big deal, > but would be nice to have my first patch approved ;) I would check in your patch, but we need mscott's approval. As far as I know, I don't think anyone else can do Thunderbird reviews (but I'm probably wrong).
not a big bug but i seen that the patch was made over a month ago and never reviewed/checked in
Comment 10•20 years ago
|
||
(In reply to comment #8) > I would check in your patch, but we need mscott's approval. As far as I know, I > don't think anyone else can do Thunderbird reviews (but I'm probably wrong). david does as well, cc'ing him. :)
Flags: blocking-aviary1.0?
Comment 11•20 years ago
|
||
this is definetly not a stop ship bug....
Flags: blocking-aviary1.0? → blocking-aviary1.0-
Flags: blocking-aviary1.0mac+
Flags: blocking-aviary1.0-L10N+
Flags: blocking-aviary1.0-
Flags: blocking-aviary1.0+
Comment 12•20 years ago
|
||
navegante: please don't plus bugs only the triage commitee can do this.
Flags: blocking-aviary1.0mac-
Flags: blocking-aviary1.0mac+
Flags: blocking-aviary1.0-L10N-
Flags: blocking-aviary1.0-L10N+
Flags: blocking-aviary1.0-
Flags: blocking-aviary1.0+
Comment 13•20 years ago
|
||
It's taken since June to decide this?
Comment 14•20 years ago
|
||
[accidentally closed the tab too early, so apologies for extra bugmail.] Scott, since the patch has been reviewed, why not sr it and have it checked in for 1.0?
Updated•20 years ago
|
QA Contact: daniel.bugmail → help-documentation
Updated•20 years ago
|
Component: Help Documentation → Mail Window Front End
Comment 15•20 years ago
|
||
Is this also on trunk now? If so, should it get "aviary-landing" keyword?
Comment 16•20 years ago
|
||
scott, is there anything wrong with this patch? why not check it in?
OS: Windows 2000 → All
Hardware: PC → All
Comment 17•19 years ago
|
||
Comment on attachment 151039 [details] [diff] [review] change brandshortname to brandFullName sr=me for trunk only. assuming the patch is still up to date.
Attachment #151039 -
Flags: superreview?(mscott) → superreview+
Comment 18•18 years ago
|
||
The existing patch had bitrotted (said malformatted when I tried to apply it). Here is an updated patch.
Attachment #151039 -
Attachment is obsolete: true
Updated•18 years ago
|
Whiteboard: [checkin needed]
Updated•18 years ago
|
QA Contact: help-documentation → mscott
Comment 19•18 years ago
|
||
mozilla/mail/locales/en-US/chrome/messenger/aboutDialog.dtd 1.5
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Thunderbird 3
Version: unspecified → Trunk
Updated•18 years ago
|
Attachment #222723 -
Flags: approval-branch-1.8.1?(mscott)
Updated•18 years ago
|
Attachment #222723 -
Flags: approval-branch-1.8.1?(mscott) → approval-branch-1.8.1+
Updated•18 years ago
|
Whiteboard: [checkin needed (1.8 branch)]
Comment 20•18 years ago
|
||
mozilla/mail/locales/en-US/chrome/messenger/aboutDialog.dtd 1.3.4.2
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Thunderbird 3 → Thunderbird2.0
Version: Trunk → 2.0
Updated•18 years ago
|
Flags: blocking-aviary1.0mac-
Flags: blocking-aviary1.0-L10N-
Flags: blocking-aviary1.0-
Comment 21•17 years ago
|
||
verified fixed for 1.8.1.3 using (Thunderbird 2 RC1) Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620
Keywords: fixed1.8.1 → verified1.8.1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•