245944 - potential crash [@ nsMsgIncomingServer::ConfigureTemporaryReturnReceiptsFilter]

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[timeless]

This is from inspection based on reading a random talkback report for mozilla1.7

2036                          newFilter->CreateAction(getter_AddRefs
(filterAction));
//return: nsresult indicating OOM at least
2037                          filterAction->SetType
(nsMsgFilterAction::MoveToFolder);
//crash if you don't check rv or out.

Comment 1

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to comment #0)
> //crash if you don't check rv or out.

seems odd, but I'm not finding the above fragment in *any* revision of nsMsgIncomingServer.cpp on lxr. I checked several revisions dated before and after timeless' comment.

why would i not be finding it?

Comment 3

[timeless]

oh, those comments were from me about the code. coders shouldn't normally add such lines to code, they should fix the code.

(note: i've actually added lines like that for one mozilla module, but not mail)

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Nothing I've had problems with but... might as well fix it so we can close this old bug.

Comment 5

[David :Bienvenu]

Comment on attachment 280361 [details] [diff] [review]
proposed fix

sure, thx.

Comment 6

[Magnus Melin [:mkmelin]]

Checking in mailnews/base/util/nsMsgIncomingServer.cpp;
/cvsroot/mozilla/mailnews/base/util/nsMsgIncomingServer.cpp,v  <--  nsMsgIncomingServer.cpp
new revision: 1.260; previous revision: 1.259
done

->FIXED