245957 - calendar mozconfig specifies optimized options.

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Justin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040221 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040221 Firefox/0.8

The mozconfig in calendar sets optimized options. These should be left to the
builder to set in their own mozconfig.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Justin]

Attachment: removes optimized config flags

I simply removed the --enable-optimized, --disabled-debug and --disable-tests

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Yup, agreed.
Anh while we are hacking it, i think the parts about static needs to go to. the
mozconfig should only give you sunbird, not a sunbird with specialized stuff.
compare to the ff mozconfig.
Also, we should test if the cookie extenstion can go, now that we don't build
firefox anymore. (cookie was needed for the profile migration iirc)

Comment 3

[Justin Wood (:Callek)]

-->New

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: updated patch

This patch also removes the stuff about static builds.
It also disables some necko protocols and the cookie extension.

Comment 5

[Mostafa Hosseini]

Comment on attachment 151904 [details] [diff] [review]
updated patch

Shouldn't this :
+ac_add_options
--enable-necko-protocols=default,-data,-gopher,-keyword,-viewsource
be:
+ac_add_options
--disable-necko-protocols=default,-data,-gopher,-keyword,-viewsource

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

checked in

Comment 7

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!