246011 - "LICENSE": missing .txt extension, Unix-style line-endings, content

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Noam Avnery]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040608 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7) Gecko/20040608 Firefox/0.8.0+

Start - Programs - Mozilla Firefox - License brings the "open with.." dialog,
because the target file has no extention.
With a (say) .TXT extention it will be opened by Notepad.

Reproducible: Always
Steps to Reproduce:
1. Start - Programs - Mozilla Firefox
2. Click on "License"
Actual Results:  
Windows brings the "Open with.." dialog, since the file has no extention.

Expected Results:  
The file should be opened by a text editor.
This will be solved if the file was renamed to "License.txt", so it will be
opened with Notepad.

Version: 0.9 RC

Comment 1

[David Tenser [:djst]]

From the Designed for Windows XP Application Specification:

"Do not place shortcuts to documents, such as Readme files, in the Start menu.
If you have important information that the user should see, consider displaying
that information during the install process or on the help menu of the application."

How about morphing this into a request for the removal of License and
Readme.txt? Or should I file a new bug instead?

Comment 2

[David Tenser [:djst]]

Forgot to add a link to the source of the information.

Comment 3

[Thomas]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040803
Firefox/0.9.3 StumbleUpon/1.994
same here...
license should be renamed to license.txt

Can't this be easily changed to be included in 1.0PR?

Comment 4

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041018 Firefox/1.0

confirming

->NEW

Comment 5

[Thomas]

Ok, recapitulation.
* In the Mozilla Suite Nightly I'm using it is correct (licence.txt).
* In the Mozilla Suite 1.8b1 it is also correct (license.txt)
* In Firefox 1.0.4 it is not correct (just LICENSE, in capitals)
* In Deer Park Alpha 1 it is also not correct (also LICENSE, in capitals)

Comment 6

[Reed Loden [:reed]]

Thunderbird does this correctly, so why don't we? http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mail/LICENSE.txt

Comment 7

[Reed Loden [:reed]]

From a further look into Firefox's source, it seems Fx uses browser/EULA as a license file instead of browser/LICENSE (which is the actual tri-license). However, there are places where we do stuff to LICENSE that should probably be done to EULA instead. Thunderbird doesn't have the full tri-license in its source like Fx does (it has the EULA in LICENSE.txt).

Comment 8

[Steffen Wilberg]

The Firefox installer displays the file "EULA" (http://lxr.mozilla.org/mozilla1.8/source/browser/EULA), while the app dir contains the file "LICENSE" (http://lxr.mozilla.org/mozilla1.8/source/browser/LICENSE), which is the MPL 1.1.

The problem with LICENSE is that
- it doesn't have the .txt extension, so Windows doesn't know how to open it
- it uses Unix-like line-endings, which certain Windows editors don't recognize
- the license itself is probably not enough if you compare it to the new about:license, which contains a bunch of other licenses as well.

So maybe we should replace it with either
- http://lxr.mozilla.org/mozilla1.8/source/toolkit/content/license.html
- a note to open about:license in the browser
- EULA.txt.

Thunderbird ships the EULA as LICENSE.txt.

Comment 9

[Gervase Markham [:gerv]]

OK, this is what should happen for both Firefox and Thunderbird:

- The LICENSE file should contain the Firefox EULA, not the MPL or anything else
- If we have a translated EULA, it should contain that too, with the form and 
  arrangement as decided in other recent bugs
- The file should be shipped as LICENSE.txt so it opens sensibly on Windows
- The file should have CR/LF line endings, so it opens sensibly on all OSes
- The link should be removed from the Start menu, in line with the Windows 
  guidelines

Feel free to split, morph or file bugs as necessary to ensure this.

Over and out :-)

Gerv

Comment 11

[Gervase Markham [:gerv]]

OK. The Firefox EULA is now the MPL. Therefore, the LICENSE file contains the correct text. And about:licence now exists, which is the primary and canonical source of licence information. So I'm much less worried about this file.

The only remaining issue is if an entry is still added to the Start menu. If that still happens, someone should file a new bug to have it removed.

I'm going to close this bug.

Gerv