246031 - theme manager looks like extension manager if theme's contents.rdf doesn't contain chrome:name

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Steffen Wilberg]

Just tested Arvid's standalone Qute. His contents.rdf didn't contain
chrome:name. The result was that the theme manager had no themePreviewArea.

The js console displays:
Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIXULChromeRegistry.getSelectedSkin]" nsresult:
"0x80004005 (NS_ERROR_FAILURE)" location: "JS frame ::
chrome://mozapps/content/extensions/extensions.js :: Startup :: line 85" data: no]

context:
if (!isExtensions) {
    gExtensionsView.addEventListener("richview-select", onThemeSelect, false);
    var cr = Components.classes["@mozilla.org/chrome/chrome-registry;1"]
                       .getService(Components.interfaces.nsIXULChromeRegistry);
    gCurrentTheme = cr.getSelectedSkin("global");
    
    var useThemeButton = document.getElementById("useThemeButton");
    useThemeButton.hidden = false;
  }

line 85 is this one: gCurrentTheme = cr.getSelectedSkin("global");

We might want to reject installation of broken themes. Besides that, Qute works
normally though.

Comment 1

[Steffen Wilberg]

Tested with the 0.9 RC: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040608 Firefox/0.8.0+

Comment 2

[David Tenser [:djst]]

Also, the button Use Theme is missing and the title says Extensions.

On a more serious notice, upon changing theme, all opened tabs are blanked and
all history is wiped from each tab. Anyone knows the bug number for that?

Comment 3

[Steffen Wilberg]

You're right, it has the appearance of the extension manager.

The theme switching bug is bug 245327.

Comment 4

[Robert Strong (they/them - no direct email)]

*** Bug 306724 has been marked as a duplicate of this bug. ***

Comment 5

[Robert Strong (they/them - no direct email)]

Is this still a problem with 1.5?

Comment 6

[Steffen Wilberg]

WFM with Firefox 1.5.