246094 - "Open in Tabs" from a bookmark folder overwrites existing open tabs

Status: RESOLVED DUPLICATE of bug 216346

(Firefox :: Tabbed Browser, defect)

Description

[Aurelien Marchand]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040207 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040207 Firefox/0.8

If you did not open a blank tab, all the new tabs will appear at the end of the
tab list. If you _did_ open a blank tab, the first tab will be overwritten by
the first tab from the group, while the open tabs from the group will open at
the end of the tab list. You also lose the history information from the first
tab that got overwritten.

Reproducible: Always
Steps to Reproduce:
0- make sure you have in your bookmark toolbar a group made by "Bookmark all
tabs in group".
1- open several sites using tabs.
2- ctrl-t to open a new (blank) tab
3- select the "Open in tabs" from the bookmark toolbar where your put the group

Comment 1

[S. Ali Tokmen]

In my experiments, the "open in tabs" command ALWAYS overwrites the pre-existing
tabs, which in some cases could disturb browsing.

Perhaps that command should ALWAYS create a new tab for every bookmark

Ali Tokmen
http://www.alishomepage.com

Comment 2

[Tracy Walker [:tracy]]

Seeing this with recent 0.9+ branch builds on windows.

-open a few sites in tabs
-Go to Bookmarks
-Right click on one of the bookmark folders
-Select Open in Tabs

tested results: 
The bookmarks from the selected folder are opened in new tabs.  All previously
opened tabs are gone.

expected results:
The bookamrks from the selected folder are opened in new tabs but appended to
any already open tabs.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

-> vlad :D

Comment 4

[Asaf Romano (gone)]

Simple fix: just turn off browser.tabs.loadFolderAndReplace

Comment 5

[Asaf Romano (gone)]

Attachment: per my comment

Comment 6

[Mike Connor [:mconnor]]

whoa.  When did we decide to change prefs?  This was WONTFIXed a long time ago,
why are we changing this at the last minute?

This is a huge change that shouldn't be happening now.

Comment 7

[Asaf Romano (gone)]

Comment on attachment 156709 [details] [diff] [review]
per my comment

from #developers:

...
<Mano> mconnor: (i wasn't here) why?
<shaver> "because"
<mconnor> Mano: a) "becuase"
<shaver> "because shut up, that's why!"
<mconnor> b) its way too late to make a huge UE change
<shaver> haha
...

I agree with shaver (i.e. removing review request).

Comment 8

[chris hofmann]

trying to shutdown for PR.  if there is demand for this seems like an extension
could fix.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

*** This bug has been marked as a duplicate of 216346 ***