Closed Bug 246094 Opened 16 years ago Closed 15 years ago

"Open in Tabs" from a bookmark folder overwrites existing open tabs

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

RESOLVED DUPLICATE of bug 216346

People

(Reporter: artaxerxes2, Assigned: vlad)

Details

(Keywords: dataloss, Whiteboard: see comments #6 & #7)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040207 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040207 Firefox/0.8

If you did not open a blank tab, all the new tabs will appear at the end of the
tab list. If you _did_ open a blank tab, the first tab will be overwritten by
the first tab from the group, while the open tabs from the group will open at
the end of the tab list. You also lose the history information from the first
tab that got overwritten.

Reproducible: Always
Steps to Reproduce:
0- make sure you have in your bookmark toolbar a group made by "Bookmark all
tabs in group".
1- open several sites using tabs.
2- ctrl-t to open a new (blank) tab
3- select the "Open in tabs" from the bookmark toolbar where your put the group
Summary: when many tabs opened, "Open in Tabs" from tab toolbar overrides first tab if last tab is blank → when many tabs opened, "Open in Tabs" from bookmark toolbar overrides first tab if last tab is blank
In my experiments, the "open in tabs" command ALWAYS overwrites the pre-existing
tabs, which in some cases could disturb browsing.

Perhaps that command should ALWAYS create a new tab for every bookmark

Ali Tokmen
http://www.alishomepage.com
Seeing this with recent 0.9+ branch builds on windows.

-open a few sites in tabs
-Go to Bookmarks
-Right click on one of the bookmark folders
-Select Open in Tabs

tested results: 
The bookmarks from the selected folder are opened in new tabs.  All previously
opened tabs are gone.

expected results:
The bookamrks from the selected folder are opened in new tabs but appended to
any already open tabs.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-aviary1.0PR?
OS: Linux → All
Hardware: PC → All
Summary: when many tabs opened, "Open in Tabs" from bookmark toolbar overrides first tab if last tab is blank → "Open in Tabs" from a bookmark folder overwrites existing open tabs
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
-> vlad :D
Assignee: bugs → vladimir
Simple fix: just turn off browser.tabs.loadFolderAndReplace
whoa.  When did we decide to change prefs?  This was WONTFIXed a long time ago,
why are we changing this at the last minute?

This is a huge change that shouldn't be happening now.
Comment on attachment 156709 [details] [diff] [review]
per my comment

from #developers:

...
<Mano> mconnor: (i wasn't here) why?
<shaver> "because"
<mconnor> Mano: a) "becuase"
<shaver> "because shut up, that's why!"
<mconnor> b) its way too late to make a huge UE change
<shaver> haha
...

I agree with shaver (i.e. removing review request).
Attachment #156709 - Flags: review?(vladimir)
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
trying to shutdown for PR.  if there is demand for this seems like an extension
could fix.
Flags: blocking-aviary1.0PR+ → blocking-aviary1.0PR-
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

*** This bug has been marked as a duplicate of 216346 ***
Status: REOPENED → RESOLVED
Closed: 16 years ago15 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.