Closed Bug 24611 Opened 26 years ago Closed 25 years ago

rename API

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Platform:
x86
Windows 98
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: cathleennscp, Assigned: dveditz)

Details

(Whiteboard: [pdt-]trivial work, fixes in dveditz's tree already.)

OLD NEW ------- ------- startInstall -> initInstall abortInstall -> cancelInstall finalizeInstall -> performInstall or commitInstall
need the changes in by beta 1.
Target Milestone: M14
we have broken the backward compatibility, so let's just get our API straight for the last time.
Keywords: beta1
have we decided which name we're going to use for finalizeInstall?
Alright, I'll crumble under the pressure and change my vote to performInstall() thus tipping the seesaw. I think we should have a majority for performInstall() now.
Putting on PDT- radar for beta1. API names are like dirty laundry...don't air in public :-) Won't hold beta for this bug.
Whiteboard: [PDT-]
Appealing PDT decision -- in this case the API names are more like DOM names or HTML tags. They are not internal calls, these are what anyone trying to install additional languages, components or skins will use (see the l10n group's ambitious plans for M14, for example). These three calls in fact are required in all install scripts.
Whiteboard: [PDT-] → trivial work, fixes in dveditz's tree already.
yes, we do not want to rewrite our product install script (and qa's test cases) more than once... need to be done by beta1.
reassign to dveditz, since he already have the changes ready to go.
Assignee: cathleen → dveditz
pdt - if you have a fix, go ahead and checkin, you don't need pdt+ for checkin
Whiteboard: trivial work, fixes in dveditz's tree already. → [pdt-]trivial work, fixes in dveditz's tree already.
Status: NEW → ASSIGNED
Fixed: initInstall, cancelInstall, performInstall
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Build: 2000-02-15-10-M14(WIN), 2000-02-15-09-M14(MAC), 2000-02-15-10-M14(LINUX) New APIs work! Test cases, a_abortinstall and a_adddelcomp have been rewritten to use the new naming convention. The trigger page from http://jimbob/trigger2.html now will trigger a_abortinstall.xpi and a_adddelcomp.xpi from the drop-down menu.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.