Closed Bug 246243 Opened 17 years ago Closed 16 years ago

Wrong accesskey values for migration UI

Categories

(Firefox :: Migration, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: marcoos, Assigned: marcoos)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Safari and Camino items in the migration dialog have wrong accesskey values
(words instead of letters):

<!ENTITY importFromCamino.label         "Camino">
<!ENTITY importFromCamino.accesskey     "Camino">
<!ENTITY importFromSafari.label         "Safari">
<!ENTITY importFromSafari.accesskey     "Safari">

while it should be something like:

<!ENTITY importFromCamino.label         "Camino">
<!ENTITY importFromCamino.accesskey     "C">
<!ENTITY importFromSafari.label         "Safari">
<!ENTITY importFromSafari.accesskey     "S">

(browser/migration/migration.dtd in the en-US.jar archive)
Status: UNCONFIRMED → NEW
Ever confirmed: true
this is not a blocker.  We should fix this, certainly, but its not blocker severity.
Severity: blocker → minor
Attached patch Patch (obsolete) — Splinter Review
Patch.
Updating URL. This bug is still in Deer Park Alpha 2. I'll submit a patch for
the trunk in the evening.
Summary: Wrong accesskey values for migration UI in Firefox 0.9 RC → Wrong accesskey values for migration UI
ok. I'll review it
Assignee: bugs → gandalf
Attached patch Patch (trunk)Splinter Review
As I promised, here's the patch.
Attachment #165797 - Attachment is obsolete: true
Attachment #189545 - Flags: review?(gandalf)
Attachment #189545 - Flags: approval1.8b4?
Attachment #189545 - Flags: review?(gandalf) → review+
Can you check it in, please?
Attachment #189545 - Flags: approval1.8b4? → approval1.8b4+
Checking in migration.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/migration/migration.dtd,v
 <--  migration.dtd
new revision: 1.4; previous revision: 1.3
done
Assignee: gandalf → marek.stepien
Target Milestone: --- → Firefox1.1
Version: unspecified → Trunk
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.