246400 - Text in Add-Ons Manager Displays Should Be Selectable and Copyable

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Brian G.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040608 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040608 Firefox/0.8.0+

i think it would be handy if the text in the extenstion mangers about dialog box
for specific extentions were selectable text.
so it'd be easy to copy and paste version numbers when trouble shooting or
talking about what versions of extensions you have.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.



Expected Results:  
made the text in extensions About dialogs selectable text

Comment 1

[Seth Kinast]

This should be marked as severity=enh as it's definitely low-priority.

But I like it ;)

Comment 2

[Ali Ebrahim]

Confirming since we have selectable text in About Firefox and Download
Properties windows.

Priority: minor

Comment 3

[Samir L. Boulema]

Nice enhancement :D

Comment 4

[Jeff Walden [:Waldo]]

Note that the vast majority of the text in About Mozilla Firefox and half the
text in Download Properties isn't selectable.  Most dialogs don't have
selectable text, and I'm not considering just Firefox.  If this is fixed, keep
in mind that the selectable text needs to look nice like the About MozFx text
(i.e., no ugly outer textbox showing).

Comment 5

[Unknown W. Brackets]

Attachment: Make extension versions selectable.

I basically copied this functionality from aboutDialog.* in browser, but it
seems to work for me.

All it does is makes the version (#extensionVersion) a textbox with no border
or -moz-appearance, and a white background.  It also focuses the "accept"
button by default to avoid the textbox being selected.

Who would I request review from, if this patch is good enough?

-[Unknown]

Comment 6

[Unknown W. Brackets]

Comment on attachment 150724 [details] [diff] [review]
Make extension versions selectable.

Darn, I bled something else into it.  Ignore the change to
mozilla/toolkit/mozapps/extensions/content/extensions.xml.....

-[Unknown]

Comment 7

[Brian G.]

another way to do this might be to leave the about diaog how it is in the RC and
when you select an extention have the ability to Right Click... Copy Extension Info.
And not even have to mess with changing the appearance of the about dialog.

Comment 8

[Robin Monks]

*** Bug 250077 has been marked as a duplicate of this bug. ***

Comment 9

[Jens Bannmann]

Unknown, you should attach an updated version of that patch without those
extensions.xml changes, possibly updated to the newest CVS revisions of the
affected files (if existing), and request review for the patch.

Comment 10

[Unknown W. Brackets]

Attachment: Patch against latest trunk.

Updated attachment against current trunk.  I'm afraid I don't know who to
request review from... but I'll annotate it here so my changes make sense:

> acceptButton.focus();
This is here to foxus the accept button by default (instead of the about box.)

> <textbox id="extensionVersion" readonly="true" crop="right"/>
Make it a textbox, unchangable of course.

> background-color: #FFFFFF;
> -moz-appearance: none;
> border: none;
Get rid of the textbox-like appearance so it looks like any other text (stolen
from aboutDialog.css, if I remember.)

I applied it to all three themes since that seemed the most logical.  Not sure
if Qute is being updated anymore, but Thunderbird uses it - no?

Thanks,
-[Unknown]

Comment 11

[Jens Bannmann]

Comment on attachment 170326 [details] [diff] [review]
Patch against latest trunk.

Mike, can you review this? Trivial change, but a great usability impact...

Comment 12

[Dave Townsend [:mossop]]

Comment on attachment 170326 [details] [diff] [review]
Patch against latest trunk.

This patch fails to apply. It is also unclear just what the benefit of being able to select the version number is here.

Comment 13

[B.J. Herbison]

In reply to comment 12: The benefit: When I make a problem report I try to include full information. When I can't copy the version information I need to type it, which is slower and can be error prone depending on the length and complexity of the version string.  This enhancement would make it faster and easier to give more accurate information.

Comment 14

[Dave Townsend [:mossop]]

I meant to ask what the point of just making the version selectable was. It seems that there are other things that would be more helpful for diagnostics like copying the full list of add-ons rather than just a single one.

Comment 15

[B.J. Herbison]

Sorry, I was going by the title of the bug: "Text in an extension's About dialog should be selectable"  All text should be selectable.  (OK, maybe not CAPTCHAs, but everything else.)

Comment 16

[Frank Yan (:fryn)]

This is also frustrating when the text in an extension about dialog contains url links to more information.

Comment 20

[David E. Ross]

Actually all text and text-like displays by all internal components of Mozilla applications should be selectable and copyable.  However, the focus here is on Toolkit's Add-ons Manager displays of extensions and plugins.  See the news.mozilla.org newsgroup thread at <news://news.mozilla.org:119/[e-mail]>.  

Note that, in SeaMonkey, if I select [Help > About Plugins], [Help > Troubleshooting Information], or [Help > About SeaMonkey] on the menu bar, the internally-generated displays are indeed selectable as text.  In Thunderbird, if I select [Help > Troubleshooting Information] on the menu bar, the internally-generated display is also selectable as text; but if I select [Help > About Thunderbird], none of the display can be selected.  (I might submit a separate bug report on this latter situation.)  The other cases cited in this paragraph illustrate that selecting and copying text and text-like internally-generated displays are possible.  

(Regarding Troubleshooting Information, see bug #726605 for Toolkit and bug #727521 for Thunderbird.)

Comment 26

[Mark Striemer [:mstriemer]]

This is fixed in the HTML version. Some text still isn't selectable as there is some XUL still remaining but all of the add-on info should now be copy-able.