246705 - About Calendar dialog opens with no height, html content in iframe is invisible

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040608
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040608, 20040609

The Help | About Calendar dialog opens with zero content height, so only the
window title and borders are visible.

Reproducible: Always
Steps to Reproduce:
1. Help | about
2.
3.

Actual Results:  
Opens but only frame is visible, no space to show contents.  Can resize frame to
show contents, but should not have to.

Expected Results:  
Opens with visible contents.

regression

Comment 1

[gekacheka]

Attachment: calendar.js patch: move displayCalendarVersion, specify a height

Specify a height for the dialog.  About.html content is displayed in an iframe,
but according to bug 80713, iframe cannot automatically size to content, so fix
by specifying a height.  This may not have been the (whole) problem, as the
components around the iframe (tab, button) were not shown either, but
specifying a height does address the problem.

Also moved displayCalendarVersion next to openAboutDialog, and added comments
specifying that displayCalendarVersion is for "about calendar", and
openAboutDialog is for "about sunbird", so it is clearer why there are two
functions (and two xul files, about.xul and aboutDialog.xul) that do similar
things.

Comment 2

[Mostafa Hosseini]

Checked in. Thanks

Comment 3

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!