246740 - import->file forces into default calendar [prompt for each]

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Rodger]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040614
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040614

I want to create a second calendar called USHolidays.  I can do this easily with
a right click in the "calendars" area and selection of "new calendar".  However,
I can not get an ics to use it to load the calendar. The default "My Calendar"
is Always used even if it is not selected.  I can unselect the default and
select the USHolidays, but import only uses the default.  I am using calendar
from the 9th of June 2004 and the nightly build shown above with windows xp. 
There does not appear to be a method to create a calendar and specify an ics to
use while creating the calendar.  That would be great.  Import may have been
"meant" for that purpose, but it does not allow a new instantiation of a
calendar in the process of the import.

Reproducible: Always
Steps to Reproduce:
1. create a new calendar
2. unselect the default
3. select the new
4. import an ics
5. nothing shows up in the new calendar
6. reselect the default
7. everything is there
Actual Results:  
see above

Expected Results:  
all the new imported events should have been in the new "selected" calendar.
Also the import process could have asked which calendar and if the calendar did
not exist it could have created the new calendar on the fly with the new events.

Comment 1

[Justin Wood (:Callek)]

modified summary slightly to better say what was meant, if I understood correctly.

This is two bugs in one it seems...

Selected calendar not used on import.

Need UI to select `calendar` when importing, (including option to create a new
calendar to import into.

This bug can easily be used for both imo, the selected should be an easier fix,
though the UI part would be a bit harder.  I'll try and confirm asap if no-one
beats me to it.

Comment 2

[gekacheka]

Attachment: importExport.js patch: fix addEventsToCalendar to pass calPath to editNewEvent, move calPath out of loop, add try finally

When importing user is given choice whether to import all, or prompt
for each (, or discard all).
If import all: Works for me (imported into selected calendar).
If prompt for each, then bug: always defaults to default calendar.

Patch: fixes bug so dialog defaults to selected calendar.

Adds calendarPath parameter to editNewEvent
so the calendar path will be the default for the imported event.

Added try ... finally to make sure gICalLib.batchMode = false on exit.

calendarPath defaulting moved outside the loop.

getSelectedCalendarPathOrDefault function added
(will also be needed for adding tasks).

Tested on Moz1.7.3, SB 0.2a (Moz1.8a4)

Comment 3

[Justin Wood (:Callek)]

*** Bug 220652 has been marked as a duplicate of this bug. ***

Comment 4

[Mostafa Hosseini]

Comment on attachment 159912 [details] [diff] [review]
importExport.js patch: fix addEventsToCalendar to pass calPath to editNewEvent, move calPath out of loop, add try finally

Patch checked in. Thanks

Comment 5

[Mostafa Hosseini]

Fixed in CVS.

Comment 6

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!