246905 - Expired Certificate shows inconsistent Date and Time

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Constantine A. Murenin]

Expired Certificate alert shows inconsistent Date and Time. 

The problem is that
<http://lxr.mozilla.org/mozilla/source/security/manager/pki/resources/content/serverCertExpired.js>
uses .toLocaleString() JS-function (bug 153586), while some other C++ part of
the same dialogue uses nsIDateTimeFormat. 

Function .toLocaleString() shows date in the long date format, while other parts
of the PSM UI use short date format. 

The solution is to fix serverCertExpired.js to use nsIDateTimeFormat, and to use
kDateFormatShort as the format for the date. 

I'll try to work on a patch sometime soon.

Comment 1

[Constantine A. Murenin]

Attachment: screen-shot

Comment 2

[Constantine A. Murenin]

Attachment: the patch for serverCertExpired.js

Change serverCertExpired.js to use the same Date and Time format as that of
nsNSSDialogs.cpp. 

http://lxr.mozilla.org/mozilla/source/security/manager/pki/resources/content/serverCertExpired.js

http://lxr.mozilla.org/mozilla/source/security/manager/pki/resources/locale/en-US/pippki.properties

http://lxr.mozilla.org/mozilla/source/security/manager/pki/src/nsNSSDialogs.cpp

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 153483 [details] [diff] [review]
the patch for serverCertExpired.js

sr=[e-mail]

/be

Comment 4

[Simon Montagu :smontagu]

I checked this in with Kaie's approval. Thank you, Constantine.

Comment 5

[Kai Engert [:KaiE:]]

Should we get this on 1.8 branch?