Closed Bug 246989 Opened 20 years ago Closed 12 years ago

Import of preferences correctly carries over all proxy settings except SOCKS server version

Categories

(Firefox :: Migration, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: bugzilla-mozilla.20.esrever_otua, Unassigned)

Details

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040615 Firefox/0.9
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040615 Firefox/0.9

Clean install of Firefox 0.9 from
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/0.9/firefox-0.9-i686-linux-gtk2+xft.tar.gz
On first run it offers to import preferences etc; point it at default Fedora
Core 2 Mozilla 1.6 install and it brings everything over correctly, including
the proxy settings for my configured SOCKS proxy, however, it *doesn't*
correctly carry over the setting of SOCKS version 4 in Mozilla 1.6, instead
leaving Firefox set to SOCKS version 5.  This prevents Firefox from working
until the setting is found and correctly manually later.

Reproducible: Always
Steps to Reproduce:
1.Clean install of Firefox 0.9 from
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/0.9/firefox-0.9-i686-linux-gtk2+xft.tar.gz
2.On first run it offers to import preferences etc; point it at default Fedora
Core 2 Mozilla 1.6 install


Actual Results:  
It brings everything over correctly, including the proxy settings for my
configured SOCKS proxy, however, it *doesn't* correctly carry over the setting
of SOCKS version 4 in Mozilla 1.6, instead leaving Firefox set to SOCKS version 5

Expected Results:  
Correctly carry over the configured SOCKS server version from Mozilla 1.6
So the migration stuff doesn't just blindly copy prefs.js anymore, huh?

http://www.mozilla.org/quality/networking/docs/netprefs.html

We need to copy/set:

network.proxy.socks_version
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
Assignee: firefox → nobody
Component: Preferences → Migration
QA Contact: mconnor → migration
Re: Comment 1, no we do not for prefs.js it seems (for user.js we do). See
nsSeamonkeyProfileMigrator.cpp, line 295 and following, line 561 and line 562.
Well you should carry over that value. Some people are in SOCKS4-only environments. This effectively sets them on SOCKS 5.

Here's the code that probably controls:



1321     else if (!mSOCKSProxyHost.IsEmpty() && mSOCKSProxyPort > 0) {
1322         host = &mSOCKSProxyHost;
1323         if (mSOCKSProxyVersion == 4) 
1324             type = kProxyType_SOCKS4;
1325         else
1326             type = kProxyType_SOCKS;

The preferences are read into the variables via Init()
"This" should say "Not copying that line..."
The Mozilla/SeaMonkey migrator is gone. As for other migrators, they don't import proxy settings (Instead, we default to system proxy settings).
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.