Closed Bug 246998 Opened 20 years ago Closed 9 days ago

Re-(re-)enable progress spinner on loading tabs

Categories

(Camino Graveyard :: Tabbed Browsing, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mikepinkerton, Unassigned)

References

Details

Attachments

(1 file)

thanks to bug 203349, we had to remove the progress spinner. This bug is a
placeholder to re-enable them when we have a fix. Maybe the new tab widget
improves this?
Status: NEW → ASSIGNED
Target Milestone: --- → Camino1.0
In the meantime, lets try to get an interim static indicator for loading tabs. I
like the idea of a globe that's either faded, or gradient-faded.
2004051715 (v0.8b) contains spinners on the right side of each tab which disable
close buttons and reintroduce the content smearing while loading.  Is this an
inadvertent regression?
Ouch.  I was fooled by the numerals in the 20040517 build, thinking it was the
20040617 0.8RC.  Nevermind.
Depends on: 249518
*** Bug 184355 has been marked as a duplicate of this bug. ***
With the new tabs from .9 alpha(s) do we still want to add the spinner to the tabs?
(In reply to comment #5)
> With the new tabs from .9 alpha(s) do we still want to add the spinner to the
tabs?

I think we want them (and also a real spinner for the throbber instead of the
gifs), but there's no indication that the underlying issues that caused bug
203349 have been fixed (unless some of smfr's gfx and widget cleanup over the
past few months have fixed it by accident).  

When Geoff was working on the new tabs (0.8+ builds from last fall), there were
builds available with the new tabs and the spinners, and the tearing/whatever
still occurred.  AFAIK changing tab widgets didn't change anything wrt this
problem....
Pushing out.
Target Milestone: Camino1.0 → Camino1.1
In reality, the spinner doesn't tell the user any more information than a static image. We might want to consider something that indicates the progress of the page loading. I propose the use of 3 grey spheres of increasing constrast to indictate 30%, 60% and 90% progress.
(In reply to comment #8)
> In reality, the spinner doesn't tell the user any more information than a
> static image.

Neither does a progress bar, really, especially on a broadband connection.

cl
*** Bug 346140 has been marked as a duplicate of this bug. ***
For those who weren't here in the active spinner era, the favicon replaces the spinner when the page is loaded.
Assignee: mikepinkerton → nobody
Status: ASSIGNED → NEW
Component: General → Tabbed Browsing
QA Contact: tabbed.browsing
Target Milestone: Camino1.1 → Camino1.2
Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.
Target Milestone: Camino1.6 → ---
Assignee: nobody → stuart.morgan
Attached patch fixSplinter Review
The weirdly permanent dirty regions that were partially responsible for the tearing have been gone for a while, so this should Just Work. I didn't see any problems in cursory tests (except for the spinner being in the wrong place, which this fixes), so I say we flip the switch and let people bang on it and we'll watch for fallout.
Attachment #275330 - Flags: review?(murph)
You should probably get pageload numbers with and without this change.
Are there instructions somewhere on running those tests?
Comment on attachment 275330 [details] [diff] [review]
fix

While we run those pageload performance tests... r=me on the code.
Attachment #275330 - Flags: review?(murph) → review+
mento, is there any good way of running pageload tests without just checking this in and watching the boxes?
(In reply to comment #17)
> mento, is there any good way of running pageload tests without just checking
> this in and watching the boxes?

Timely topic: http://groups.google.com/group/mozilla.dev.quality/browse_thread/thread/7f3c6194f2f260f2/b1fcae3c5b29170f#b1fcae3c5b29170f

Summary: Re-enable progress spinner on loading tabs → [patch] Re-enable progress spinner on loading tabs
Comment on attachment 275330 [details] [diff] [review]
fix

Since letting this rot indefinitely while I wait for the ability to get numbers from a test that I can't run doesn't seem like a good plan, how about we just check this in go from there?
Attachment #275330 - Flags: superreview?(mikepinkerton)
Comment on attachment 275330 [details] [diff] [review]
fix

sr=pink
Attachment #275330 - Flags: superreview?(mikepinkerton) → superreview+
Landed on trunk and MOZILLA_1_8_BRANCH. Everyone keep your eyes peeled for perf issues; if need be we can pull the spinner back out and replace it with a static icon to indicate loading.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.11
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
Re-opening, since we had to disable them again and switch to static spinners (bug 415949), due to a variety of issues we didn't have time to fix. In addition to the dependencies here, we also had issues with white squares painting behind the spinners any time they were moved, and Smokey reported seeing a lesser version of the old tearing-on-scroll behavior.

I spent some time trying to fix most of these issues, and never found a way that didn't involve manually running the animation on the main thread, which made the animation so choppy that it was unlivable, and made things feel really slow.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: [patch] Re-enable progress spinner on loading tabs → Re-(re-)enable progress spinner on loading tabs
Assignee: stuart.morgan → nobody
Status: REOPENED → NEW
Keywords: fixed1.8.1.12
Target Milestone: Camino1.6 → ---
Status: NEW → RESOLVED
Closed: 17 years ago9 days ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: