Closed Bug 247147 Opened 16 years ago Closed 16 years ago

Perl errors when building in browser/themes/pinstripe/browser

Categories

(Firefox Build System :: General, defect)

PowerPC
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhpedemonte, Assigned: bryner)

Details

Attachments

(1 file, 3 obsolete files)

I get the following errors:

make[5]: Entering directory
`/Users/pedemonte/builds/fox10/mozilla/objdbg/browser/base/skin/mac'
+++ making chrome
/Users/pedemonte/builds/fox10/mozilla/objdbg/browser/base/skin/mac  =>
../../../../dist/bin/chrome/classic.jar
+++ updating chrome ../../../../dist/bin/chrome/installed-chrome.txt
+++	skin,install,url,jar:resource:/chrome/classic.jar!/skin/classic/browser/
updating: skin/classic/browser/browser.css (stored 0%)
updating: skin/classic/browser/Toolbar-small.png (stored 0%)
updating: skin/classic/browser/Toolbar.png (stored 0%)
updating: skin/classic/browser/bookmarks/Bookmarks-toolbar.png (stored 0%)
  adding: icon.png (stored 0%)
+++ overriding skin/classic/browser/pref/Options.png
skin/classic/browser/pref/pref.css 
updating: skin/classic/browser/pref/Options.png (stored 0%)
updating: skin/classic/browser/pref/pref.css (stored 0%)
Use of uninitialized value in substitution (s///) at
/System/Library/Perl/5.8.1/File/Spec/Unix.pm line 54, <JARFILE> line 36.
Use of uninitialized value in substitution (s///) at
/System/Library/Perl/5.8.1/File/Spec/Unix.pm line 55, <JARFILE> line 36.
Use of uninitialized value in string eq at
/System/Library/Perl/5.8.1/File/Spec/Unix.pm line 56, <JARFILE> line 36.
Use of uninitialized value in substitution (s///) at
/System/Library/Perl/5.8.1/File/Spec/Unix.pm line 56, <JARFILE> line 36.
Use of uninitialized value in substitution (s///) at
/System/Library/Perl/5.8.1/File/Spec/Unix.pm line 57, <JARFILE> line 36.
Use of uninitialized value in string eq at
/System/Library/Perl/5.8.1/File/Spec/Unix.pm line 58, <JARFILE> line 36.
Use of uninitialized value in substitution (s///) at
/System/Library/Perl/5.8.1/File/Spec/Unix.pm line 58, <JARFILE> line 36.
Use of uninitialized value in concatenation (.) or string at
/System/Library/Perl/5.8.1/File/Spec/Unix.pm line 59, <JARFILE> line 36.
make[5]: Leaving directory
`/Users/pedemonte/builds/fox10/mozilla/objdbg/browser/base/skin/mac'
Attached patch patch (obsolete) — Splinter Review
This fixes the perl errors, but I'm not sure if this is the correct change to
make.
Summary: Perl errors when building in browser/base/skin/mac → Perl errors when building in browser/themes/pinstripe/browser
Comment on attachment 150960 [details] [diff] [review]
patch

If this is the right fix, it needs to be updated to the new themes structure.
I'm seeing the same errors in winstripe/browser.
Attachment #150960 - Attachment is obsolete: true
Attached patch patch (obsolete) — Splinter Review
Same error, different location.
As Stephen noticed this should be changed inside the winstripe/jar.mn. This
fixes the build errors/warning on OS/2 for me.
Attachment #151470 - Flags: review?(bryner)
Attachment #152069 - Flags: review?(bryner)
Comment on attachment 151470 [details] [diff] [review]
patch

Did you test whether this breaks the preview image for the theme in
tools->themes?
Attachment #152069 - Attachment is obsolete: true
Attachment #152069 - Flags: review?(bryner)
Attachment #151470 - Attachment is obsolete: true
Attachment #151470 - Flags: review?(bryner)
Attachment #156071 - Flags: review?(bryner)
Attachment #156071 - Flags: review?(bryner) → review+
checked in on the trunk
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Keywords: aviary-landing
Second trunk checkin 2004-12-12 12:58.
Keywords: aviary-landing
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.