247174 - Mail button looks horked when using small icons and show icons and text

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[weimin Feng]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9

customize toolbar, use small icons, show "icons and text", then the email button
become nasty

Reproducible: Always
Steps to Reproduce:
1.custozie toolbar
2.use small icon
3.show "icons and text"

Actual Results:  
email button become nasty

Expected Results:  
should be nice and beautiful :)

Comment 1

[Ali Ebrahim]

Confirming & tweaking summary.

Comment 2

[Piotr Komoda]

This is also a localization Bug, mail button becomes nasty when translation for
"mail" word is wider than icon.

Comment 3

[Blake Ross]

I don't see this. Is it still happening?

Comment 4

[Piotr Komoda]

Attachment: screenshot

Screenshot of bug presence in polish version of Firefox 0.9.2.

Comment 5

[Blake Ross]

It still occurs in the latest branch nightly, though? Can someone give me solid
reproduction steps?

Comment 6

[weimin Feng]

(In reply to comment #5)
> It still occurs in the latest branch nightly, though? Can someone give me solid
> reproduction steps?

1.custozie toolbar
2.use small icon
3.show "icons and text"
u didnt see that? this bug shows in different version of firefox from
0.9.0-0.9.1+, and shows in different locolization build as well as different themes.

Comment 7

[weimin Feng]

(In reply to comment #3)
> I don't see this. Is it still happening?

oh, i forgot to mention, in english version of firefox, the mail button looks ok
as long as it still stay in the option panel, but when u move it to toolbar,
this bug shows up.

Comment 8

[Alex Eng]

Hopefully, these steps to reproduce are clearer.

1. Start with a new Firefox user profile, then launch Firefox.  In its initial
state, the default Firefox theme is used, the size of the icons on the
Navigation Toolbar is small, and the Mail button is not present.
2. Right-click on the Navigation Toolbar and choose "Customize" from the context
menu.
3. The floating Customize Toolbar window appears.  Leave the "Use Small Icons"
option checked, and drag the Mail icon to any toolbar.

Observe that the small Mail icon appears normal on the Customize Toolbar window.
 However, once the Mail icon is placed on the toolbar, the icon image looks
distorted, or in the words of the bug reporter, "horked."

The Mail icon image is normal if the toolbar icon size is set to large (by
unchecking "Use Small Icons" in the Customize Toolbar window).  But the image is
distorted again if the toolbar icon size is reset to small.

Reproducible on Firefox 0.9.1+
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.2) Gecko/20040811 Firefox/0.9.1+

Comment 9

[Alex Eng]

Attachment: Screen shot of Navigation Toolbar with "horked" Mail icon

Comment 10

[amano]

It may be that this occurs only to people that had a localized build installed.

I have a german Fx 0.9.3 build installed. If I download a current branch nightly
to another location and run it, the mail button is displayed incorrectly (small
icons, show "icons and text").

Comment 11

[Alex Eng]

The problem occurs when the toolbar shows icons and text and the icon size is
small.  The small mail icon looks fine when only the icons are shown.

Still reproducing on Firefox 0.10 (build ID 2004090307)
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20040903 Firefox/1.0 PR
(NOT FINAL)

Comment 12

[Anbo Motohiko]

Attachment: Patch to toolbarbutton.xml

This patch is introduced by flyson in bugzilla.mozilla.gr.jp 3844 comment #12.
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=3844#c12

Comment 13

[Anbo Motohiko]

Attachment: Patch to toolbarbutton.xml

This is correct patch.
Sorry for bug spams...

Comment 14

[amano]

It is a big visual glitch. The one line fix seems quick and easy. Maybe this can
make it into PR.

Adding chofmann to the CC list to get on the drivers' radar.

Comment 15

[amano]

I compiled Firefox with this patch manually applied and this patch definitely
fixes the problem for me: try
http://www.pryan.org/mozilla/firefox/amano/Fx-2004-09-08-AVIARY-O1-Gopher-MNG-Exp.exe

BTW, toolbarbutton.xml is in mozilla/toolkit/content/widgets

Comment 16

[Kevin Gerich]

Reassigning to Ben. Patch seems to work as advertised but someone other than me
should make the call, even though it is a one liner.

Comment 17

[amano]

Setting the blocking 1.0 flag to help getting this onto Ben's radar. Rather get
this into PR1 than waiting for 1.0 since the patch is already here.

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 158013 [details] [diff] [review]
Patch to toolbarbutton.xml

r+a=[e-mail]

Comment 19

[Alex Eng]

Verified fixed on Firefox 1.0 Preview Release (2004-09-10 release candidate)
Build ID 2004091016
Mozilla/5.0 (Windows; U; Win98; rv:1.7.3) Gecko/20040910 Firefox/0.10

Comment 20

[Asa Dotzler [:asa]]

*** Bug 258820 has been marked as a duplicate of this bug. ***