247541 - SOAP decoder sometimes encodes incorrect xsi:type

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Harshal Pradhan]

This happens when trying to send an array of structs. I have a fix.

Comment 1

[Harshal Pradhan]

Attachment: Fix

If no name is specified for the value being encoded, EncodeSimpleValue attempts
to guess at a suitable name by walking up the type hierarchy till we find
something usable. The loop that does this uses the typeNS variable that
contains the namespace for the type, and clobbers its value. This looks
incorrect since we want to later use the value for encoding the type
information. This caused the encoder to put structs that were part of an array
in the schema namespace instead of the correct targetnamespace.

The fix is to make the loop not use typeNS, but currentURI. Looks like that was
the intention all along, but someone had a brainfart or something.

Also includes unrelated cleanup: GetNativeType() always returns OK, so get rid
of the nsresult return.

Comment 2

[Harshal Pradhan]

Comment on attachment 151131 [details] [diff] [review]
Fix

timeless, I'm hoping you might be interested in this. Would you please review?

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 151131 [details] [diff] [review]
Fix

sr=jst

Comment 4

[Harshal Pradhan]

Thanks for the reviews.

Checked in.

Comment 5

[timeless]

Comment on attachment 151131 [details] [diff] [review]
Fix

hierarcy(sp)

:)

Comment 6

[Harshal Pradhan]

(In reply to comment #5)
> hierarcy(sp)

Duh! I'll fix that the next time I checkin to this file.