247547 - 'series_categories' uses an auto-increment column, 'category_id', which produces a sequence with too long a name

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Jeff Dubrule]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040404 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040404 Firefox/0.8

When checksetup.pl creates series_categories, with auto-incrementing column
'category_id'.

In Postgres and Oracle, a sequence is created (implicitly in Postgres, explicity
in Oracle) to store the next serial number.

However, the sequence name would be 'series_categories_category_id_seq'. which
exceeds Oracle's maximum column name length.


Reproducible: Always
Steps to Reproduce:
Run checksetup.pl or:

create sequence series_categories_category_id_seq;

Actual Results:  
create sequence series_categories_category_id_seq
                *
ERROR at line 1:
ORA-00972: identifier is too long


Expected Results:  
Sequence created.

Comment 1

[Jeff Dubrule]

I'd suggest changing the column name to simply be 'id', which results in: 

    series_categories_id_seq

which is under the limit.

Comment 2

[Dave Miller [:justdave]]

Is there a way to explicitly override the name of the series which is created?

Comment 3

[Bradley Baetz (:bbaetz)]

Whats hte maximum size for a sequence? Its been a while since I've used orcale.

You could chagne the name, but then the calling code would have the special case
this.

Comment 4

[Jeff Dubrule]

The maximum length is 30 characters.

I'd suggest we change the name from 'category_id' to 'id', and be done.  It only
gets used a couple of places in the code.

Comment 5

[Gervase Markham [:gerv]]

This one's probably mine. Sure, we can change the name. It's a bit annoying
because it's inconsistent, but I can live with that.

Gerv

Comment 6

[Dave Miller [:justdave]]

we use 'id' by itself in lots of other tables.

Comment 7

[Dave Miller [:justdave]]

normally I would say schema changes are scary on a branch, but I'll OK this 
(and the other one) for 2.18 provided they go in as part of your charting
megapatch, since they are both related to chart schema. :)

Comment 8

[Gervase Markham [:gerv]]

Fixed by checkin for bug 225687.

Gerv