247859 - "Desktop" selection in download prefs should really download to desktop

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Peter Weilbacher]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8a2) Gecko/20040618
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7) Gecko/20040616 Firefox/0.9

In FF 0.9 the downloads all go to the installation dir (or MOZILLA_HOME if
defined). Instead, when selecting "Desktop" in the Download section of the
Preferences dialog, they should go there on OS/2, too.

I already tried changing this with this small patch (similar to what other
platforms do in the code after the FF 0.9 release):

--- content\mozapps\downloads\pref-downloads.js.orig    2004-06-21
00:57:48.000000000 +0100
+++ content\mozapps\downloads\pref-downloads.js.PmW     2004-06-21
01:08:54.000000000 +0100
@@ -256,6 +256,9 @@

 function getSpecialFolderKey(aFolderType)
 {
+#ifdef XP_OS2
+  return aFolderType == "Desktop" ? "Desk" : "Home";
+#endif
   return "Home";
 }

But this only gives "Error: doEnabling is not defined" on the JS console and the
selection box does not even appear. Hmm...

Reproducible: Always
Steps to Reproduce:

Comment 1

[Mike Kaply [:mkaply]]

Need to change nsHelperAppDlg.js as well.

I'll attach a patch for this and check it in .

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Add XP_OS2 paths to download code

Comment 3

[Mike Kaply [:mkaply]]

Fix checked into the aviary branch and trunk

Comment 4

[Peter Weilbacher]

Yes, this fixes the prefs part of the problem. But now that this works, one can
see that the "Desktop" button in the Download Manager still opens the Firefox dir.
I tried to understand the problem, but I just don't find my way through the
snarl of JS code at this level. The problematic function seems to be
onDownloadShowFolder() in toolkit/mozapps/downloads/content/downloads.js, but I
didn't find out where the "Home" dir comes into play again here.

Comment 5

[Mike Kaply [:mkaply]]

The open button can't ever open the desktop because the desktop is already open.

There is no clever way on OS/2 to do a second open of the desktop.

But you are correct. This is yet another file that needs the #ifdef XP_OS2 that
I did for these files.

Comment 6

[Mike Kaply [:mkaply]]

I checked in the downloads.js fix.

It was only needed on aviary and the trunk, since the change Ben made wasn't in 0.9.

Hopefully this is fixed now.

Please try again. Thanks!

Comment 7

[Peter Weilbacher]

Yes, to me this looks fixed now.