Closed Bug 247919 Opened 20 years ago Closed 20 years ago

Add support for wallet.crypto.autocompleteoverride

Categories

(Camino Graveyard :: Preferences, enhancement)

PowerPC
macOS
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino0.9

People

(Reporter: stuart.morgan+bugzilla, Assigned: jaas)

Details

Attachments

(1 file, 1 obsolete file)

We should support the Moz pref to ignore autocomplete=off, but currently don't
since we use our own implementation. This may well be too subtle for a GUI pref,
but we should at least honor it as a hidden pref.
in what cases would we do this? we don't want to allow overriding.
> we don't want to allow overriding.

Um... why not?  If a user is finding and changing a hidden pref, they are taking
responsibility for their own actions. Ultimately, the browser is the user's
tool, and if the user feels that keychain provides them with enough security for
their online bank, why should we prevent them from keeping it there (as opposed
to, say, on a stick note).

Besides, some sites abuse autocomplete=off, using it even if there is no serious
security risk to someone else accessing the account. Why should we prevent
knowledgable users from making their own determinations as to which sites are
safe to store in their keychains, rather than allowing any site to do so at
their whim?

(See bug 124065 for the discussion of creating the pref in Netscape.)
because banks have made it very clear they don't want to give users that power,
at the risk of blocking us. i guess moz does have this hidden pref, though that
amazes me. i'll talk to asa later today.
after talking with asa, i guess if mozilla does it, it's ok for us to do it too.
i guess we should re-use the prefname even if it's a different system, right?
Status: NEW → ASSIGNED
Target Milestone: --- → Camino1.0
> i guess we should re-use the prefname even if it's a different system, right?

That was my thought, since the effect appears to be exactly the same. Using the
same pref eases transitions from other Moz browsers, makes user-discovery of the
pref more likely, and means one less new pref to add to an already very large list.
Attachment #153015 - Flags: review?
Josh is rewwritting the prefs at the momment so I'm ccing him.
we should look at this sooner, it doesn't really have much to do with the prefs
rewrite.
Target Milestone: Camino1.0 → Camino0.9
Attachment #153015 - Flags: review?(joshmoz)
Attachment #153015 - Flags: review?
Attachment #153015 - Flags: review?(joshmoz) → review-
Fixes the patch so it applies to latest CVS, also don't bail if pref service is
unavailable. If pref service is unavailable, just use false for the pref. No
reason to bail.
Assignee: pinkerton → joshmoz
Attachment #153015 - Attachment is obsolete: true
Comment on attachment 164511 [details] [diff] [review]
updated and improved patch v2.0

sr=pinkerton
Attachment #164511 - Flags: superreview+
landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Should this be working in 2004110508 (v0.8+)? It doesn't at a site (ba-ca.com)
on which it does using Firefox.
We have issues with frames. It probably won't work on a frames site. I don't
know what the issues are, and it should be a separate bug anyway.
Blocks: 273239
Frames problem filed as bug 273239.
No longer blocks: 273239
You need to log in before you can comment on or make changes to this bug.