24796 - [dogfood] mail "reply" is busted: no address, no contents quote

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Jim Roskind]

Trying today's M14 build on NT: When I reply to an email, all I get is the 
subject line filled in.  The address list is empty.  The contents are not filled 
in.

Comment 1

[David :Bienvenu]

I've seen this too - I tracked it down to the lack of a load group when the 
quote url is run, which breaks the memory cache. If I ignore this error when 
initializing the CacheManagerStreamListener, then quoting works again. But I 
don't know anything about this code or what might have broken it. I've sent 
e-mail to mscott and rpotts in case they might have a clue.

Comment 2

[Chris Waterson]

jar: did your include my changes at 13:55 today? (curious if this might've been 
my script hackery...)

Comment 3

[David :Bienvenu]

this was happening last night, Chris.

Comment 4

[Jim Roskind]

My problems showed up in Saturday morning's automated M14 build (kicked around 
8am, available by around 10am). Folks can try the comercial build to see a demo 
:-(.    It would not have included Waterson's afternoon hacking.

Comment 5

[Scott MacGregor]

This is a regression caused by the M13 fix judson and I worked on for Bug # oh 
heck I don't have the bug number handy. I'll take a look at it later today. 
Basically his change in the cache channel shouldn't return an error if we have a 
null load group....Our fix was checked in friday night into M13 and M14.

Comment 6

[Scott MacGregor]

Here's a patch to fix the problem. David B. can you be the reviewer for this and 
I'll get permission to check it into the m13 branch? the change is trivial..part 
of Jud's fix friday night changed the semantics of the cache entry channel's 
Init method. It used to allow for null load groups. He added line that looks 
like:
if (!mLoadGroup) return NS_ERROR_NOT_INITIALIZED.

it's legal to not have a load group and that's how the code works. My fix is to 
just take out that line that got added (I was involved in this bug so I can 
verify that this it's okay to take out his line).

I'd like to check it in today but I'm planning on going back and watching the 
playoff game today on tv =). I'll try to come back later and check this in 
assuming I get the reviews.

Comment 7

[Scott MacGregor]

Attachment: the fix to the cache code

Comment 8

[David :Bienvenu]

yes, looks fine r=bienvenu

Comment 9

[Scott MacGregor]

I've checked the fix into the tip. I'm trying to get approval now to check it 
into the M13 branch.

Comment 10

[Scott MacGregor]

the fix has been checked in to M13 and m14.

Comment 11

[pmock]

changing qa assigned to [e-mail]

Comment 12

[Chris McAfee]

*** Bug 24788 has been marked as a duplicate of this bug. ***

Comment 13

[pmock]

Verified as fixed on win32, linux, and macos using the following builds.
ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/2000-01-24-01-M13/bac
kup/install.exe
ftp://sweetlou/products/client/seamonkey/unix/linux_glibc/2.2/x86/2000-01-24-01-
M13/netscape-i686-pc-linux-gnu.tar.gz
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/2000-01-24-01-M13/NSMacIn
staller-M13.sea.bin

Verified under plain text and html compose windows. :)