Closed Bug 247960 Opened 20 years ago Closed 20 years ago

The 2 panes of bookmarkmanager do not interact

Categories

(Firefox :: Bookmarks & History, defect, P2)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.0beta

People

(Reporter: Peter6, Assigned: myk)

References

Details

(Keywords: fixed-aviary1.0, Whiteboard: ETA: 7/19/2004)

Attachments

(1 file, 1 obsolete file)

Patch to get this working
2.21 KB, patch
vlad
: review+
asa
: approval-aviary+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040620 Firefox/0.9.0+

see summary

Reproducible: Always
Steps to Reproduce:
1.open new BM
2.click on a folder in left pane
3.it should open in the right, but does not
4.click on a folder in the right pane
5.it should show in the left, but does not 
Actual Results:  
absolutely nothing, there is no interaction between the 2

Expected Results:  
work as intended
Flags: blocking1.0?
Confirming with same build number on XP.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: p_ch → myk
Flags: blocking1.0? → blocking1.0+
Priority: -- → P2
Target Milestone: --- → Firefox1.0beta
Just asking, is it necessary to have the 2 panels automatically synchronized? As
it is now, drag and drop is easier because one doesn't have to scroll up/down
through a long list, IMHO.
Agree with the last comment. What I would expect from a sync is only a refresh
when I perform real changes on the other pane. 
E.g. when I rename/copy/delete a folder or bookmark on the right pane, I would
expect the changes to be reflected on the left pane. But the left pane should
stay unaffected when I simply expand/collapse a folder in the right pane.

Somehow I think that reporter had Windows Explorer in mind, which I wonder
whether it would be good for any platform.
I didn't have anything in mind, except something that actually works.
Not in particular IE or Explorer, any filemanager I've seen works more or less 
like that.
(In reply to comment #4)
> I didn't have anything in mind, except something that actually works.
Hi Peter. Hoping that you didn't misunderstand my comment. I would like to know
the exact meaning of interaction. Actually, this bug is very important. Sooner
or later, it will need some clear and well elaborated specifications.
Whiteboard: ETA: 7/19/2004
Having the left panel simplifies navigation when there is a large number of
folders because, unlike the right panel, it only displays folders and thus
requires less scrolling to get to a specific folder.

However, if selecting a folder in the left panel does not bring that folder to
the top of the right panel (like in any decent file manager), then there is no
need to have the left panel.
Present behavious makes no sense. You expect the selected left panel to show
it's files in the right panel. Should work like Explorer or any other file manager.
Attached patch Patch to get this working (obsolete) — — Splinter Review 
I don't know if anyone is already working on this, but this patch sets the ref
on the bookmarks-view tree based on selection in the bookmark-folders-view
tree.  It also hides the folder tree and splitter if the window is passed a uri
on open.
I don't know if anyone is already working on this, but this patch sets the ref
on the bookmarks-view tree based on the selection in the bookmark-folders-view
tree.  It also hides the folder tree and splitter if the window is passed a uri
on open.
Comment on attachment 153162 [details] [diff] [review]
Patch to get this working

Somehow this got posted twice.
Attachment #153162 - Attachment is obsolete: true
*** Bug 251517 has been marked as a duplicate of this bug. ***
Comment on attachment 153163 [details] [diff] [review]
Patch to get this working

With this patch, clicking a folder in the folder pane properly displays the
contents of that folder in the bookmarks pane.	Ben, can you review?
Attachment #153163 - Flags: review?(bugs)
Does the patch solve the problem? if yes, why is it so long in getting reviewed?

This bug is the fourth most "popular" in the red list of
Regressions/confirmed/annoying bugs on
http://forums.mozillazine.org/viewtopic.php?t=105453
Do not misquote "my" lists please.
It's only on that place because of the order I keep.
Be assured that Ben or Vladimir will check this one in if they need to.
*Peter(6)*

Most popular by number of votes, not by place on Peter's list.


Comment on attachment 153163 [details] [diff] [review]
Patch to get this working

Mike, can you take a look at this simple fix?
Attachment #153163 - Flags: review?(bugs) → review?(mconnor)
Comment on attachment 153163 [details] [diff] [review]
Patch to get this working

I'm going to kick this one to vlad, since he's taken on the "bookmarks guru"
mantle of late.
Attachment #153163 - Flags: review?(mconnor) → review?(vladimir)
Well, did you kick this to Vlad yet? What about the proposed patch (now 2 weeks
old)?


er, note that the review request is set to vlad.  Also, in some cases two weeks
is a small amount of time.  We're trying to kill the PR1 buglist first, 1.0
buglist second, so we can do the l10n freeze etc etc.
Comment on attachment 153163 [details] [diff] [review]
Patch to get this working

looks good, r=vladimir

I've been playing with it for a bit now, and it feels correct.	It still
doesn't solve the other issues with the sidebar, but it solves this particular
issue quite well.  Requesting aviary approval.
Attachment #153163 - Flags: review?(vladimir)
Attachment #153163 - Flags: review+
Attachment #153163 - Flags: approval-aviary?
Comment on attachment 153163 [details] [diff] [review]
Patch to get this working

a=asa (yo Yo YO!)
Attachment #153163 - Flags: approval-aviary? → approval-aviary+
In on aviary and trunk.  Thanks for the patch, Richard!
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
The interface still needs a little work, because the folders in the right pane
should not be allowed to open in the same manner as the left pane.  A double
click should open the folder, and move into it (similer to most to pane tree
views, like  Windows Explorer)
Keywords: fixed-aviary1.0
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: